Issue 2664143002: Revert "Debugging in kernel shaping up."

Issue 2664143002: Revert "Debugging in kernel shaping up." (Closed)

Created:
3 years, 10 months ago by jensj

Modified:
3 years, 10 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Debugging in kernel shaping up." This reverts commit 2d5147be9d7435c06dd892d145d8717b6d1f62d5. INTPTR_MAX doesn't exist on all builders. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/d0e0ef52eff5d176bda8be4fe8e0605e6cd98524

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -224 lines)			Patch
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	runtime/vm/kernel.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/kernel.cc	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	runtime/vm/kernel_binary.cc	View	6 chunks	+6 lines, -41 lines	0 comments	Download
M	runtime/vm/kernel_reader.cc	View	2 chunks	+0 lines, -49 lines	0 comments	Download
M	runtime/vm/kernel_to_il.cc	View	4 chunks	+3 lines, -64 lines	0 comments	Download
M	runtime/vm/object.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	runtime/vm/object.cc	View	3 chunks	+8 lines, -41 lines	0 comments	Download
M	runtime/vm/object_service.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

jensj

3 years, 10 months ago (2017-01-31 10:26:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:2) manually as
d0e0ef52eff5d176bda8be4fe8e0605e6cd98524 (presubmit successful).