Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2664133003: Return to the standard of 80 chars per lines for ObjectiveC files. (Closed)

Created:
3 years, 10 months ago by noyau (Ping after 24h)
Modified:
3 years, 10 months ago
Reviewers:
sdefresne, Dan Beam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return to the standard of 80 chars per lines for ObjectiveC files. This was changed by a roll of clang-format and is causing issues for ios commits. BUG=686650 TBR=jam@chromium.org

Patch Set 1 #

Patch Set 2 : Reflow comments. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M .clang-format View 1 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
noyau (Ping after 24h)
Sylvain, please review.
3 years, 10 months ago (2017-01-31 11:00:28 UTC) #3
sdefresne
rs lgtm (I have no idea what the syntax of this file)
3 years, 10 months ago (2017-01-31 11:04:04 UTC) #4
noyau (Ping after 24h)
On 2017/01/31 11:04:04, sdefresne wrote: > rs lgtm (I have no idea what the syntax ...
3 years, 10 months ago (2017-01-31 11:45:14 UTC) #5
Dan Beam
On 2017/01/31 11:45:14, noyau wrote: > On 2017/01/31 11:04:04, sdefresne wrote: > > rs lgtm ...
3 years, 10 months ago (2017-01-31 16:41:07 UTC) #6
Dan Beam
https://codereview.chromium.org/2664133003/diff/20001/.clang-format File .clang-format (right): https://codereview.chromium.org/2664133003/diff/20001/.clang-format#newcode35 .clang-format:35: PPAPI_END_MESSAGE_MAP$" ---
3 years, 10 months ago (2017-01-31 16:41:59 UTC) #8
noyau (Ping after 24h)
3 years, 10 months ago (2017-01-31 16:47:58 UTC) #9
Message was sent while issue was closed.
On 2017/01/31 16:41:59, Dan Beam wrote:
> https://codereview.chromium.org/2664133003/diff/20001/.clang-format
> File .clang-format (right):
> 
> https://codereview.chromium.org/2664133003/diff/20001/.clang-format#newcode35
> .clang-format:35: PPAPI_END_MESSAGE_MAP$"
> ---

Yes, I didn't realised that the --- were significant, sorry.

Powered by Google App Engine
This is Rietveld 408576698