Refactor pdf_scripting_api.js to remove the PDFMessagingHost in OOP PDF

Refactor pdf_scripting_api.js to remove the PDFMessagingHost in OOP PDF

This merges the PDFMessagingHost functionality into PDFViewer and renames
PDFMessagingClient to PDFScriptingAPI. PDFMessagingHost provided an extra
layer of indirection between the page communicating with the PDF viewer
and the viewer itself which made it difficult to add new functionality.

BUG=303491
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269548

[Lei Zhang, 2014-05-06 21:23:40]

In the CL description, you meant to say PDFMessagingFoo and not PDFScriptingFoo,
right?

[Lei Zhang, 2014-05-06 21:33:47]

https://codereview.chromium.org/266413002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/pdf/pdf_scripting_api.js (right):

https://codereview.chromium.org/266413002/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/pdf_scripting_api.js:13: this.readyToReceive =
false;
Why is this variable no longer named as a private variable?

[raymes, 2014-05-07 00:30:00]

https://codereview.chromium.org/266413002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/pdf/pdf_scripting_api.js (right):

https://codereview.chromium.org/266413002/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/pdf_scripting_api.js:13: this.readyToReceive =
false;
I have a follow-up CL where I was going to use this variable from outside the
class. But I ended up getting rid of the variable altogether in the follow-up so
this shouldn't be a problem. Good catch though :)

[raymes, 2014-05-09 05:17:43]

On 2014/05/07 00:30:00, raymes wrote:
>
https://codereview.chromium.org/266413002/diff/20001/chrome/browser/resources...
> File chrome/browser/resources/pdf/pdf_scripting_api.js (right):
> 
>
https://codereview.chromium.org/266413002/diff/20001/chrome/browser/resources...
> chrome/browser/resources/pdf/pdf_scripting_api.js:13: this.readyToReceive =
> false;
> I have a follow-up CL where I was going to use this variable from outside the
> class. But I ended up getting rid of the variable altogether in the follow-up
so
> this shouldn't be a problem. Good catch though :)

ping :)

[Lei Zhang, 2014-05-09 05:32:35]

lgtm

err, forgot about this

[raymes, 2014-05-09 06:22:13]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-05-09 06:29:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/raymes@chromium.org/266413002/20001

[raymes, 2014-05-09 06:31:32]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-05-09 06:36:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/raymes@chromium.org/266413002/40001

[commit-bot: I haz the power, 2014-05-10 06:31:59]

Change committed as 269548