Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: ios/web/public/web_state/page_display_state.mm

Issue 2664113003: Moved serialization out of CRWSessionEntry. (Closed)
Patch Set: Eugene's comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/public/web_state/page_display_state.h ('k') | ios/web/web_state/page_display_state_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/public/web_state/page_display_state.mm
diff --git a/ios/web/public/web_state/page_display_state.mm b/ios/web/public/web_state/page_display_state.mm
index 378456b90118575f576be659f2cfa768a0462aac..cb1ac33a928e33f5a0655ed50683bfd09809cbd9 100644
--- a/ios/web/public/web_state/page_display_state.mm
+++ b/ios/web/public/web_state/page_display_state.mm
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "ios/web/public/web_state/page_display_state.h"
+#import "ios/web/public/web_state/page_display_state.h"
#include <cmath>
@@ -13,12 +13,24 @@
namespace web {
namespace {
+// Serialiation keys.
+NSString* const kXOffsetKey = @"scrollX";
+NSString* const kYOffsetKey = @"scrollY";
+NSString* const kMinZoomKey = @"minZoom";
+NSString* const kMaxZoomKey = @"maxZoom";
+NSString* const kZoomKey = @"zoom";
// Returns true if:
// - both |value1| and |value2| are NAN, or
// - |value1| and |value2| are equal non-NAN values.
inline bool StateValuesAreEqual(double value1, double value2) {
return std::isnan(value1) ? std::isnan(value2) : value1 == value2;
}
+// Returns the double stored under |key| in |serialization|, or NAN if it is not
+// set.
+inline double GetValue(NSString* key, NSDictionary* serialization) {
+ NSNumber* value = serialization[key];
+ return value ? [value doubleValue] : NAN;
+}
} // namespace
PageScrollState::PageScrollState() : offset_x_(NAN), offset_y_(NAN) {
@@ -93,6 +105,13 @@ inline bool StateValuesAreEqual(double value1, double value2) {
zoom_state_(minimum_zoom_scale, maximum_zoom_scale, zoom_scale) {
}
+PageDisplayState::PageDisplayState(NSDictionary* serialization)
+ : PageDisplayState(GetValue(kXOffsetKey, serialization),
+ GetValue(kYOffsetKey, serialization),
+ GetValue(kMinZoomKey, serialization),
+ GetValue(kMaxZoomKey, serialization),
+ GetValue(kZoomKey, serialization)) {}
+
PageDisplayState::~PageDisplayState() {
}
@@ -109,4 +128,26 @@ inline bool StateValuesAreEqual(double value1, double value2) {
return !(*this == other);
}
+NSDictionary* PageDisplayState::GetSerialization() const {
+ return @{
+ kXOffsetKey : @(scroll_state_.offset_x()),
+ kYOffsetKey : @(scroll_state_.offset_y()),
+ kMinZoomKey : @(zoom_state_.minimum_zoom_scale()),
+ kMaxZoomKey : @(zoom_state_.maximum_zoom_scale()),
+ kZoomKey : @(zoom_state_.zoom_scale())
+ };
+}
+
+NSString* PageDisplayState::GetDescription() const {
+ NSString* const kPageScrollStateDescriptionFormat =
+ @"{ scrollOffset:(%0.2f, %0.2f), zoomScaleRange:(%0.2f, %0.2f), "
+ @"zoomScale:%0.2f }";
+ return [NSString stringWithFormat:kPageScrollStateDescriptionFormat,
+ scroll_state_.offset_x(),
+ scroll_state_.offset_y(),
+ zoom_state_.minimum_zoom_scale(),
+ zoom_state_.maximum_zoom_scale(),
+ zoom_state_.zoom_scale()];
+}
+
} // namespace web
« no previous file with comments | « ios/web/public/web_state/page_display_state.h ('k') | ios/web/web_state/page_display_state_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698