Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: ios/chrome/browser/sessions/session_service.mm

Issue 2664113003: Moved serialization out of CRWSessionEntry. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web/BUILD.gn » ('j') | ios/web/navigation/crw_navigation_item_storage_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/sessions/session_service.mm
diff --git a/ios/chrome/browser/sessions/session_service.mm b/ios/chrome/browser/sessions/session_service.mm
index 806b528ea39b0e31a7e00caa464400a39bf22342..4112e5ac3208f31d760cfa623d7265fa6c5b3da2 100644
--- a/ios/chrome/browser/sessions/session_service.mm
+++ b/ios/chrome/browser/sessions/session_service.mm
@@ -20,8 +20,7 @@
#include "ios/chrome/browser/browser_state/chrome_browser_state.h"
#import "ios/chrome/browser/sessions/session_window.h"
#import "ios/web/navigation/crw_session_certificate_policy_manager.h"
-#import "ios/web/navigation/crw_session_controller.h"
Eugene But (OOO till 7-30) 2017/01/31 22:12:26 Could you please cleanup ios/chrome/browser/sessio
kkhorimoto 2017/02/03 00:36:09 Done.
-#import "ios/web/navigation/crw_session_entry.h"
+#import "ios/web/public/crw_navigation_item_storage.h"
#import "ios/web/public/crw_navigation_manager_storage.h"
#include "ios/web/public/web_thread.h"
@@ -216,8 +215,10 @@ - (SessionWindowIOS*)loadWindowFromPath:(NSString*)path
forClassName:@"SessionController"];
[SessionWindowUnarchiver setClass:[CRWNavigationManagerStorage class]
forClassName:@"CRWSessionController"];
- [SessionWindowUnarchiver setClass:[CRWSessionEntry class]
+ [SessionWindowUnarchiver setClass:[CRWNavigationItemStorage class]
forClassName:@"SessionEntry"];
+ [SessionWindowUnarchiver setClass:[CRWNavigationItemStorage class]
+ forClassName:@"CRWSessionEntry"];
Eugene But (OOO till 7-30) 2017/01/31 22:12:26 Should we use CRWNavigationItemStorage key instead
kkhorimoto 2017/02/03 00:36:09 The unarchiver already knows to use CRWNavigationI
// TODO(crbug.com/661633): Remove this hack.
[SessionWindowUnarchiver setClass:[SessionWindowIOS class]
forClassName:@"SessionWindow"];
« no previous file with comments | « no previous file | ios/web/BUILD.gn » ('j') | ios/web/navigation/crw_navigation_item_storage_unittest.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698