Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2634)

Unified Diff: build/toolchain/mac/BUILD.gn

Issue 2664063004: Add GN assert to prevent GOMA from being used with static analyzer. (Closed)
Patch Set: Mac changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/gcc_toolchain.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/mac/BUILD.gn
diff --git a/build/toolchain/mac/BUILD.gn b/build/toolchain/mac/BUILD.gn
index 8de58cef3654ce64df7d07bfdd3fc932717fc082..de63e5d5219e374988767010e125a848505ecf98 100644
--- a/build/toolchain/mac/BUILD.gn
+++ b/build/toolchain/mac/BUILD.gn
@@ -124,7 +124,11 @@ template("mac_toolchain") {
cc = compiler_prefix + _cc
cxx = compiler_prefix + _cxx
- if (use_clang_static_analyzer && !toolchain_uses_goma) {
+ if (use_clang_static_analyzer) {
+ # Static analysis isn't supported under GOMA. See crbug.com/687245
+ # for progress on this issue.
+ assert(!use_goma, "'use_clang_static_analyzer' cannot be used with GOMA.")
+
# Call "ccc-analyzer" or "c++-analyzer" instead of directly calling Clang.
# |wrapper_tool| sets the environment variables which are read by the
# analyzer tools.
« no previous file with comments | « build/toolchain/gcc_toolchain.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698