Read share targets from prefstore, and filter by engagement.

chrome/browser/webshare/share_service_impl.cc

Index: chrome/browser/webshare/share_service_impl.cc
diff --git a/chrome/browser/webshare/share_service_impl.cc b/chrome/browser/webshare/share_service_impl.cc
index 3df5f1641661a4807a57986eb36a1633d9e010b9..b891a49a4c7680bda3dec9f9d26fdf4ad5b53768 100644
--- a/chrome/browser/webshare/share_service_impl.cc
+++ b/chrome/browser/webshare/share_service_impl.cc
@@ -10,12 +10,15 @@
 
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
-#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/engagement/site_engagement_service.h"
+#include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/common/pref_names.h"
+#include "components/prefs/pref_service.h"
 #include "mojo/public/cpp/bindings/strong_binding.h"
 #include "net/base/escape.h"
 
@@ -125,26 +128,75 @@ void ShareServiceImpl::ShowPickerDialog(
 #endif
 }
 
+Browser* ShareServiceImpl::GetBrowser() {
+  return BrowserList::GetInstance()->GetLastActive();
+}
+
 void ShareServiceImpl::OpenTargetURL(const GURL& target_url) {
 // TODO(constantina): Prevent this code from being run/compiled in android.
 #if defined(OS_LINUX) || defined(OS_WIN)
-  Browser* browser = BrowserList::GetInstance()->GetLastActive();
+  Browser* browser = GetBrowser();
   chrome::AddTabAt(browser, target_url,
                    browser->tab_strip_model()->active_index() + 1, true);
 #endif
 }
 
+std::string ShareServiceImpl::GetTargetTemplate(const std::string& target_url) {
+  const base::DictionaryValue* share_target_dict =
+      GetPrefService()->GetDictionary(prefs::kWebShareVisitedTargets);
+
+  const base::DictionaryValue* share_target_info_dict = nullptr;
+  share_target_dict->GetDictionaryWithoutPathExpansion(target_url,
+                                                       &share_target_info_dict);
+
+  std::string url_template;
+  share_target_info_dict->GetString("url_template", &url_template);
+  return url_template;
+}
+
+PrefService* ShareServiceImpl::GetPrefService() {
+  return GetBrowser()->profile()->GetPrefs();
+}
+
+blink::mojom::EngagementLevel ShareServiceImpl::GetEngagementLevel(
+    const GURL& url) {
+  SiteEngagementService* site_engagement_service =
+      SiteEngagementService::Get(GetBrowser()->profile());
+  return site_engagement_service->GetEngagementLevel(url);
+}
+
+// static
+std::vector<std::string>
+ShareServiceImpl::GetTargetsWithSufficientEngagement() {
+  const blink::mojom::EngagementLevel kMinimumEngagementLevel =
+      blink::mojom::EngagementLevel::LOW;
+
+  const base::DictionaryValue* dict =
+      GetPrefService()->GetDictionary(prefs::kWebShareVisitedTargets);
+
+  std::vector<std::string> sufficiently_engaged_targets;
+
+  for (base::DictionaryValue::Iterator it(*dict); !it.IsAtEnd(); it.Advance()) {
+    GURL manifest_url(it.key());
+    if (GetEngagementLevel(manifest_url) >= kMinimumEngagementLevel) {
+      sufficiently_engaged_targets.push_back(it.key());
+    }
+  }
+
+  return sufficiently_engaged_targets;
+}
+
 void ShareServiceImpl::Share(const std::string& title,
                              const std::string& text,
                              const GURL& share_url,
                              const ShareCallback& callback) {
-  // TODO(constantina): Replace hard-coded manifest URL with the list of
-  // registered targets' manifest URLs.
-  constexpr char kManifestURL[] =
-      "https://wicg.github.io/web-share-target/demos/manifest.json";
-  // TODO(constantina): Pass vector of pairs of target names and manifest URLs
-  // to picker.
-  std::vector<base::string16> targets{base::ASCIIToUTF16(kManifestURL)};
+  std::vector<std::string> sufficiently_engaged_targets =
+      GetTargetsWithSufficientEngagement();
+
+  std::vector<base::string16> targets;
+  for (const std::string& target : sufficiently_engaged_targets) {

[Matt Giuca, 2017/02/03 02:40:23]

Can be const auto&

[constantina, 2017/02/08 23:25:16]

Gone.

+    targets.push_back(base::UTF8ToUTF16(target));
+  }
 
   ShowPickerDialog(targets, base::Bind(&ShareServiceImpl::OnPickerClosed,
                                        base::Unretained(this), title, text,
@@ -161,27 +213,29 @@ void ShareServiceImpl::OnPickerClosed(const std::string& title,
     return;
   }
 
-  // TODO(constantina): use manifest URL in result to look up corresponding URL
-  // template.
-  constexpr char kUrlTemplate[] =
-      "https://wicg.github.io/web-share-target/demos/"
-      "sharetarget.html?title={title}&text={text}&url={url}";
+  std::string chosen_target = base::UTF16ToUTF8(result.value());

[Matt Giuca, 2017/02/03 02:40:23]

As discussed, conversion from UTF-8 to UTF-16 (in Share), then back to UTF-8
again (here) is not ideal.

In the previous CL we discussed changing to always keep the manifest URL as a
GURL (and therefore UTF-8 inside), and returned as a GURL. Then you won't need
these conversions.

[constantina, 2017/02/08 23:25:16]

Gone.

 
+  std::string url_template = GetTargetTemplate(chosen_target);
   std::string url_template_filled;
-  if (!ReplacePlaceholders(kUrlTemplate, title, text, share_url,
-                           &url_template_filled)) {
+  if (!ReplacePlaceholders(url_template, title, text, share_url,
+                          &url_template_filled)) {
     callback.Run(base::Optional<std::string>(
         "Error: unable to replace placeholders in url template"));
     return;
   }
 
-  GURL target_url(url_template_filled);
-  if (!target_url.is_valid()) {
+  // The template is relative to the manifest URL (minus the filename).
+  // Concatenate to make an absolute URL.
+  base::StringPiece url_base(
+      chosen_target.data(),
+      chosen_target.size() - GURL(chosen_target).ExtractFileName().size());
+  const GURL target(url_base.as_string() + url_template_filled);
+  if (!target.is_valid()) {
     callback.Run(base::Optional<std::string>(
         "Error: url of share target is not a valid url."));
     return;
   }
-  OpenTargetURL(target_url);
+  OpenTargetURL(target);
 
   callback.Run(base::nullopt);
 }