Issue 2663943002: Enforce passing cwd via context rather then api.step kwargs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2663943002: Enforce passing cwd via context rather then api.step kwargs (Closed)

Created:
3 years, 10 months ago by Paweł Hajdan Jr.

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org

Target Ref:
refs/heads/master

Project:
recipe_engine

Visibility:
Public.

More Reviews

Description

Enforce passing cwd via context rather then api.step kwargs See https://groups.google.com/a/chromium.org/d/msg/infra-dev/p8Iq9v9Y4k0/w__b1zTWAQAJ for more context. BUG=685746

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	recipe_modules/step/api.py	View		4 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paweł Hajdan Jr.

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

3 years, 10 months ago (2017-01-30 20:27:21 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663943002/1

3 years, 10 months ago (2017-01-30 20:27:27 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 10 months ago (2017-01-30 20:33:13 UTC) #3

commit-bot: I haz the power

3 years, 10 months ago (2017-01-30 20:33:14 UTC) #4

Dry run: Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3409e14db7000810)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages