Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2663903002: Store exceptions with transitive files context into ByteStore. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Store exceptions with transitive files context into ByteStore. The key under which the exception context is stored, is included into ExceptionResult, so Analysis Server can include the key into the message. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d29ba1e238e2a336dfd1c4ef9ebbae96cb5f4e7a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -43 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 7 chunks +133 lines, -41 lines 1 comment Download
M pkg/analyzer/lib/src/summary/format.dart View 1 chunk +296 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 10 months ago (2017-01-30 19:28:49 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2663903002/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart File pkg/analyzer/lib/src/dart/analysis/driver.dart (right): https://codereview.chromium.org/2663903002/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart#newcode1560 pkg/analyzer/lib/src/dart/analysis/driver.dart:1560: * the exception happened was stores, this field ...
3 years, 10 months ago (2017-01-30 20:16:42 UTC) #2
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-01-30 20:49:30 UTC) #3
scheglov
3 years, 10 months ago (2017-01-30 20:57:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d29ba1e238e2a336dfd1c4ef9ebbae96cb5f4e7a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698