Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2663873002: Updated status file to allow malloc hook tests to fail while they are being de-flakified. (Closed)

Created:
3 years, 10 months ago by bkonyi
Modified:
3 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Updated status file to allow malloc hook tests to fail while they are being de-flakified. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/1bb198ccc74b19fd15af8f57b7301cb9e2bd68f7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
bkonyi
https://codereview.chromium.org/2663873002/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/2663873002/diff/1/runtime/tests/vm/vm.status#newcode299 runtime/tests/vm/vm.status:299: [ $system == linux ] # Tests are currently ...
3 years, 10 months ago (2017-01-30 19:02:56 UTC) #2
Cutch
lgtm
3 years, 10 months ago (2017-01-30 19:03:22 UTC) #3
bkonyi
3 years, 10 months ago (2017-01-30 19:06:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1bb198ccc74b19fd15af8f57b7301cb9e2bd68f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698