Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: test/debugger/debug/debug-evaluate-no-side-effect-builtins.js

Issue 2663803002: [string] Migrate String.prototype.{split,replace} to TF (Closed)
Patch Set: Remove debug-evaluate whitelisting Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/v8.gyp ('k') | test/mjsunit/string-replace.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/debugger/debug/debug-evaluate-no-side-effect-builtins.js
diff --git a/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js b/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js
index 989cb393113154acd9af58a1019c0977c724be99..f5f2976af14bb675148f86cccbfc3ed646786fc4 100644
--- a/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js
+++ b/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js
@@ -53,7 +53,10 @@ function listener(event, exec_state, event_data, data) {
if (f == "normalize") continue;
if (f == "match") continue;
if (f == "search") continue;
- if (f == "split") continue;
+ if (f == "split" || f == "replace") {
+ fail(`'abcd'.${f}(2)`);
+ continue;
+ }
success("abcd"[f](2), `"abcd".${f}(2);`);
}
}
« no previous file with comments | « src/v8.gyp ('k') | test/mjsunit/string-replace.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698