Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: test/debugger/debug/debug-evaluate-no-side-effect-builtins.js

Issue 2663803002: [string] Migrate String.prototype.{split,replace} to TF (Closed)
Patch Set: Fix test failures Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/v8.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/debugger/debug/debug-evaluate-no-side-effect-builtins.js
diff --git a/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js b/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js
index 989cb393113154acd9af58a1019c0977c724be99..17c94c64a1eeeb5afdcbec3404cb7e47615543f0 100644
--- a/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js
+++ b/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js
@@ -54,6 +54,7 @@ function listener(event, exec_state, event_data, data) {
if (f == "match") continue;
if (f == "search") continue;
if (f == "split") continue;
+ if (f == "replace") continue;
Yang 2017/01/31 11:52:44 Does String.prototype.{split,replace} with non-reg
jgruber 2017/01/31 12:49:41 Added to whitelist in new patchset.
success("abcd"[f](2), `"abcd".${f}(2);`);
}
}
« no previous file with comments | « src/v8.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698