src/debug/debug-evaluate.cc - Issue 2663803002: [string] Migrate String.prototype.{split,replace} to TF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug-evaluate.cc

Issue 2663803002: [string] Migrate String.prototype.{split,replace} to TF (Closed)

Patch Set: Properly call ToString on early exit Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/debug-evaluate.cc

diff --git a/src/debug/debug-evaluate.cc b/src/debug/debug-evaluate.cc

index 96cd98d3f26a2b47e997cb69dada1c1a92fb8744..a36926ac62075c9cc4021427374dd2cb4ff0c2f8 100644

--- a/src/debug/debug-evaluate.cc

+++ b/src/debug/debug-evaluate.cc

@@ -430,6 +430,8 @@ bool BuiltinHasNoSideEffect(Builtins::Name id) {

case Builtins::kStringPrototypeIncludes:

case Builtins::kStringPrototypeIndexOf:

case Builtins::kStringPrototypeLastIndexOf:

+ case Builtins::kStringPrototypeReplace:

+ case Builtins::kStringPrototypeSplit:

case Builtins::kStringPrototypeStartsWith:

case Builtins::kStringPrototypeSubstr:

case Builtins::kStringPrototypeSubstring: