Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2663793002: Extract reusable parts of KernelAstAdapter in a mixin. (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract reusable parts of KernelAstAdapter in a mixin. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/1275367501830f12eeedbba553729e6b81e79f77

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -250 lines) Patch
M pkg/compiler/lib/src/kernel/element_adapter.dart View 3 chunks +271 lines, -1 line 1 comment Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 10 chunks +23 lines, -249 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
https://codereview.chromium.org/2663793002/diff/1/pkg/compiler/lib/src/kernel/element_adapter.dart File pkg/compiler/lib/src/kernel/element_adapter.dart (right): https://codereview.chromium.org/2663793002/diff/1/pkg/compiler/lib/src/kernel/element_adapter.dart#newcode143 pkg/compiler/lib/src/kernel/element_adapter.dart:143: "Can only get the selector for a property get ...
3 years, 10 months ago (2017-01-30 14:40:00 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-01-30 18:59:49 UTC) #3
Johnni Winther
3 years, 10 months ago (2017-01-31 09:13:03 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1275367501830f12eeedbba553729e6b81e79f77 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698