[inspector] added test infrastructure and test for es6 modules

src/ast/scopes.cc

Index: src/ast/scopes.cc
diff --git a/src/ast/scopes.cc b/src/ast/scopes.cc
index ad1c137753e475963467df4a934f414f9d649161..2d8c286339f9229486603bb9dc040d04c236b065 100644
--- a/src/ast/scopes.cc
+++ b/src/ast/scopes.cc
@@ -1883,6 +1883,9 @@ void Scope::ResolveVariablesRecursively(ParseInfo* info) {
 VariableProxy* Scope::FetchFreeVariables(DeclarationScope* max_outer_scope,
                                          ParseInfo* info,
                                          VariableProxy* stack) {
+  // Module variables must be allocated before variable resolution
+  // to ensure that AccessNeedsHoleCheck() can detect import variables.
+  if (is_module_scope()) AsModuleScope()->AllocateModuleVariables();

[kozy, 2017/01/30 23:25:11]

Adam, could you please take a look on these lines?

Previous version of CL doesn't pass tests with crash, link to try bot with crash
stack trace [1].
I think that we should do AllocationModuleVariables here in the same way as we
do in DeclarationScope::AllocateVariables function for the same reason.. WDYT?

[1]
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.v8%2Fv8_linux_...

[adamk, 2017/01/30 23:34:35]

Can you guard this with "info != nullptr" as well? It looks like only in that
case do we call ResolveTo(), which is where this goes badly.

[kozy, 2017/01/30 23:40:40]

Done.

   // Lazy parsed declaration scopes are already partially analyzed. If there are
   // unresolved references remaining, they just need to be resolved in outer
   // scopes.