[inspector] added test infrastructure and test for es6 modules

src/ast/scopes.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/ast/scopes.h"
 
 #include <set>
 
 #include "src/accessors.h"
 #include "src/ast/ast.h"
@@ skipping 1865 matching lines @@
     for (Scope* scope = inner_scope_; scope != nullptr;
          scope = scope->sibling_) {
       scope->ResolveVariablesRecursively(info);
     }
   }
 }
 
 VariableProxy* Scope::FetchFreeVariables(DeclarationScope* max_outer_scope,
                                          ParseInfo* info,
                                          VariableProxy* stack) {
+  // Module variables must be allocated before variable resolution
+  // to ensure that AccessNeedsHoleCheck() can detect import variables.
+  if (is_module_scope()) AsModuleScope()->AllocateModuleVariables();

[kozy, 2017/01/30 23:25:11]

Adam, could you please take a look on these lines?

Previous version of CL doesn't pass tests with crash, link to try bot with crash
stack trace [1].
I think that we should do AllocationModuleVariables here in the same way as we
do in DeclarationScope::AllocateVariables function for the same reason.. WDYT?

[1]
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.v8%2Fv8_linux_...

[adamk, 2017/01/30 23:34:35]

Can you guard this with "info != nullptr" as well? It looks like only in that
case do we call ResolveTo(), which is where this goes badly.

[kozy, 2017/01/30 23:40:40]

Done.

   // Lazy parsed declaration scopes are already partially analyzed. If there are
   // unresolved references remaining, they just need to be resolved in outer
   // scopes.
   Scope* lookup =
       is_declaration_scope() && AsDeclarationScope()->was_lazily_parsed()
           ? outer_scope()
           : this;
   for (VariableProxy *proxy = unresolved_, *next = nullptr; proxy != nullptr;
        proxy = next) {
     next = proxy->next_unresolved();
@@ skipping 311 matching lines @@
   Variable* function =
       is_function_scope() ? AsDeclarationScope()->function_var() : nullptr;
   bool is_function_var_in_context =
       function != nullptr && function->IsContextSlot();
   return num_heap_slots() - Context::MIN_CONTEXT_SLOTS -
          (is_function_var_in_context ? 1 : 0);
 }
 
 }  // namespace internal
 }  // namespace v8