Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: media/cast/rtcp/test_rtcp_packet_builder.cc

Issue 266373008: Cast: Fix rtcp event dedup logic in rtcp_receiver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/cast/rtcp/test_rtcp_packet_builder.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/cast/rtcp/test_rtcp_packet_builder.h" 5 #include "media/cast/rtcp/test_rtcp_packet_builder.h"
6
6 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "media/cast/rtcp/rtcp_utility.h"
7 9
8 namespace media { 10 namespace media {
9 namespace cast { 11 namespace cast {
10 12
11 TestRtcpPacketBuilder::TestRtcpPacketBuilder() 13 TestRtcpPacketBuilder::TestRtcpPacketBuilder()
12 : ptr_of_length_(NULL), 14 : ptr_of_length_(NULL),
13 big_endian_writer_(reinterpret_cast<char*>(buffer_), kMaxIpPacketSize) {} 15 big_endian_writer_(reinterpret_cast<char*>(buffer_), kMaxIpPacketSize) {}
14 16
15 void TestRtcpPacketBuilder::AddSr(uint32 sender_ssrc, 17 void TestRtcpPacketBuilder::AddSr(uint32 sender_ssrc,
16 int number_of_report_blocks) { 18 int number_of_report_blocks) {
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 int num_events, 241 int num_events,
240 uint32 event_timesamp_base) { 242 uint32 event_timesamp_base) {
241 big_endian_writer_.WriteU32(rtp_timestamp); 243 big_endian_writer_.WriteU32(rtp_timestamp);
242 big_endian_writer_.WriteU8(static_cast<uint8>(num_events - 1)); 244 big_endian_writer_.WriteU8(static_cast<uint8>(num_events - 1));
243 big_endian_writer_.WriteU8(static_cast<uint8>(event_timesamp_base >> 16)); 245 big_endian_writer_.WriteU8(static_cast<uint8>(event_timesamp_base >> 16));
244 big_endian_writer_.WriteU8(static_cast<uint8>(event_timesamp_base >> 8)); 246 big_endian_writer_.WriteU8(static_cast<uint8>(event_timesamp_base >> 8));
245 big_endian_writer_.WriteU8(static_cast<uint8>(event_timesamp_base)); 247 big_endian_writer_.WriteU8(static_cast<uint8>(event_timesamp_base));
246 } 248 }
247 249
248 void TestRtcpPacketBuilder::AddReceiverEventLog(uint16 event_data, 250 void TestRtcpPacketBuilder::AddReceiverEventLog(uint16 event_data,
249 uint8 event_id, 251 CastLoggingEvent event,
250 uint16 event_timesamp_delta) { 252 uint16 event_timesamp_delta) {
251 big_endian_writer_.WriteU16(event_data); 253 big_endian_writer_.WriteU16(event_data);
254 uint8 event_id = ConvertEventTypeToWireFormat(event);
252 uint16 type_and_delta = static_cast<uint16>(event_id) << 12; 255 uint16 type_and_delta = static_cast<uint16>(event_id) << 12;
253 type_and_delta += event_timesamp_delta & 0x0fff; 256 type_and_delta += event_timesamp_delta & 0x0fff;
254 big_endian_writer_.WriteU16(type_and_delta); 257 big_endian_writer_.WriteU16(type_and_delta);
255 } 258 }
256 259
257 scoped_ptr<media::cast::Packet> TestRtcpPacketBuilder::GetPacket() { 260 scoped_ptr<media::cast::Packet> TestRtcpPacketBuilder::GetPacket() {
258 PatchLengthField(); 261 PatchLengthField();
259 return scoped_ptr<media::cast::Packet>( 262 return scoped_ptr<media::cast::Packet>(
260 new media::cast::Packet(buffer_, buffer_ + Length())); 263 new media::cast::Packet(buffer_, buffer_ + Length()));
261 } 264 }
(...skipping 24 matching lines...) Expand all
286 big_endian_writer_.WriteU8(0x80 | (format_or_count & 0x1F)); 289 big_endian_writer_.WriteU8(0x80 | (format_or_count & 0x1F));
287 big_endian_writer_.WriteU8(payload); 290 big_endian_writer_.WriteU8(payload);
288 ptr_of_length_ = big_endian_writer_.ptr(); 291 ptr_of_length_ = big_endian_writer_.ptr();
289 292
290 // Initialize length to "clearly illegal". 293 // Initialize length to "clearly illegal".
291 big_endian_writer_.WriteU16(0xDEAD); 294 big_endian_writer_.WriteU16(0xDEAD);
292 } 295 }
293 296
294 } // namespace cast 297 } // namespace cast
295 } // namespace media 298 } // namespace media
OLDNEW
« no previous file with comments | « media/cast/rtcp/test_rtcp_packet_builder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698