Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(87)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/fast/workers/resources/worker-xhr-onerror.js
Issue
2663643002
:
For a worker, mark relative to its wrapper map. (Closed)
Patch Set: check DOMDataStore access
Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/fast/workers/resources/worker-xhr-onerror.js
third_party/WebKit/LayoutTests/fast/workers/worker-gc-alive.html
third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/fast/workers/worker-gc-alive.html »
('j') |
third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
(function () {
2
var xhr = new XMLHttpRequest();
3
xhr.open('GET', 'does-not-exist.js');
4
xhr.onerror = () => { postMessage('done'); };
5
xhr.send();
6
})();
7
// |xhr| isn't in scope, but it will signal pending activity
8
// when the GC runs, hence will be kept alive and allowed to
9
// run to completion.
10
self.gc();
OLD
NEW
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/fast/workers/worker-gc-alive.html »
('j') |
third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp »
('J')
Issue 2663643002: For a worker, mark relative to its wrapper map. (Closed)
Created 3 years, 10 months ago by sof
Modified 3 years, 10 months ago
Reviewers: jochen (gone - plz use gerrit), haraken, Michael Lippautz, NGG1, NGG
Base URL:
Comments: 7
This is Rietveld
408576698