Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2249)

Unified Diff: chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc

Issue 266363006: Adds API tests for listRemovableStorageDevices (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleans up a few minor issues. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc
diff --git a/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc b/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc
index 1c907a53d873599d66bc32056916897858c2d047..34c1c89fcedb567808b4602148357be55c3bc581 100644
--- a/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc
+++ b/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc
@@ -10,7 +10,6 @@
#include "content/public/browser/browser_thread.h"
namespace extensions {
-
// TODO(haven): Udev code may be duplicated in the Chrome codebase.
// https://code.google.com/p/chromium/issues/detail?id=284898
@@ -42,19 +41,7 @@ static int get_device_blk_size(const std::string& path) {
return blk_size;
}
-void RemovableStorageProvider::GetAllDevices(
- DeviceListReadyCallback callback) {
- scoped_refptr<StorageDeviceList> device_list(new StorageDeviceList);
-
- // We need to do some file i/o to get the device block size
- content::BrowserThread::PostTaskAndReplyWithResult(
- content::BrowserThread::FILE,
- FROM_HERE,
- base::Bind(GetDevicesOnFileThread, device_list),
- base::Bind(callback, device_list));
-}
-
-bool RemovableStorageProvider::GetDevicesOnFileThread(
+bool RemovableStorageProvider::PopulateDeviceList(
scoped_refptr<StorageDeviceList> device_list) {
struct udev* udev;
struct udev_enumerate* enumerate;

Powered by Google App Engine
This is Rietveld 408576698