third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py - Issue 2663623003: Simplify the initialization of Git objects in Host.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

Issue 2663623003: Simplify the initialization of Git objects in Host. (Closed)

Patch Set: Remove second paragraph in comment about awesome windows git hack Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py b/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

index 4d2ae5b430a03b2b645d5379eb62f10275c7bdb3..6c6ffd289de89f9c559033e4104926b047726c62 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

@@ -63,7 +63,6 @@ class PerfTestsRunner(object):

else:

self._host = Host()

self._port = self._host.port_factory.get(self._options.platform, self._options)

- self._host.initialize_scm()

self._webkit_base_dir_len = len(self._port.webkit_base())

self._base_path = self._port.perf_tests_dir()

self._timestamp = time.time()

@@ -262,7 +261,7 @@ class PerfTestsRunner(object):

def _generate_results_dict(self, timestamp, description, platform, builder_name, build_number):

revisions = {}

path = self._port.repository_path()

- git = self._host.scm_for_path(path)

+ git = self._host.scm(path=path)

revision = str(git.commit_position(path))

revisions['chromium'] = {'revision': revision, 'timestamp': git.timestamp_of_revision(path, revision)}