Simplify the initialization of Git objects in Host.

third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py

 # Copyright (c) 2010 Google Inc. All rights reserved.
 # Copyright (c) 2009 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 47 matching lines @@
 from webkitpy.tool.commands.rebaseline import RebaselineJson
 from webkitpy.tool.commands.rebaseline import RebaselineTest
 from webkitpy.tool.commands.rebaseline_cl import RebaselineCL
 from webkitpy.tool.commands.rebaseline_server import RebaselineServer
 
 
 _log = logging.getLogger(__name__)
 
 
 class WebKitPatch(Host):
+    # FIXME: It might make more sense if this class had a Host attribute
+    # instead of being a Host subclass.
+
     global_options = [
         optparse.make_option(
             "-v", "--verbose", action="store_true", dest="verbose", default=False,
             help="enable all logging"),
         optparse.make_option(
             "-d", "--directory", action="append", default=[],
             help="Directory to look at for changed files"),
     ]
 
     def __init__(self, path):
@@ skipping 27 matching lines @@
 
         option_parser = self._create_option_parser()
         self._add_global_options(option_parser)
 
         command = self.command_by_name(command_name) or self.help_command
         if not command:
             option_parser.error("%s is not a recognized command", command_name)
 
         command.set_option_parser(option_parser)
         (options, args) = command.parse_args(args)
-        self.initialize_scm()
 
         (should_execute, failure_reason) = self._should_execute_command(command)
         if not should_execute:
             _log.error(failure_reason)
             return 0  # FIXME: Should this really be 0?
 
         result = command.check_arguments_and_execute(options, args, self)
         return result
 
     def path(self):
@@ skipping 38 matching lines @@
             return False
         if command.requires_local_commits:
             return self.scm().supports_local_commits()
         return True
 
     def command_by_name(self, command_name):
         for command in self.commands:
             if command_name == command.name:
                 return command
         return None