Convert utility process ImageWriter IPC to mojo

chrome/browser/extensions/api/image_writer_private/image_writer_utility_client_browsertest.cc

Index: chrome/browser/extensions/api/image_writer_private/image_writer_utility_client_browsertest.cc
diff --git a/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client_browsertest.cc b/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..bb6d3b5e27cb4e76b81b8db8fd50397a7c36eeec
--- /dev/null
+++ b/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client_browsertest.cc
@@ -0,0 +1,315 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.h"
+
+#include "base/bind.h"
+#include "base/callback.h"
+#include "base/files/file_path.h"
+#include "base/files/file_util.h"
+#include "base/files/scoped_temp_dir.h"
+#include "base/macros.h"
+#include "base/run_loop.h"
+#include "chrome/common/extensions/removable_storage_writer.mojom.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "content/public/browser/browser_thread.h"
+
+constexpr int64_t kTestFileSize = 1 << 15;  // 32 kB
+
+class ImageWriterUtilityClientTest : public InProcessBrowserTest {
+ public:
+  ImageWriterUtilityClientTest() {
+    test_device_ = base::FilePath().AppendASCII(
+        extensions::mojom::RemovableStorageWriter::kTestDevice);
+    EXPECT_TRUE(temp_dir_.CreateUniqueTempDir());
+  }
+
+  void FillImageFileWithPattern(int pattern) {
+    EXPECT_TRUE(base::CreateTemporaryFileInDir(temp_dir_.GetPath(), &image_));
+
+    base::RunLoop run_loop;
+    content::BrowserThread::PostBlockingPoolTaskAndReply(
+        FROM_HERE,
+        base::Bind(&ImageWriterUtilityClientTest::FillFile, image_, pattern),
+        run_loop.QuitClosure());
+
+    run_loop.Run();
+  }
+
+  void FillDeviceFileWithPattern(int pattern) {
+    device_ = image_.ReplaceExtension(FILE_PATH_LITERAL("out"));
+
+    base::RunLoop run_loop;
+    content::BrowserThread::PostBlockingPoolTaskAndReply(
+        FROM_HERE,
+        base::Bind(&ImageWriterUtilityClientTest::FillFile, device_, pattern),
+        run_loop.QuitClosure());
+
+    run_loop.Run();
+  }
+
+  enum RunOption { WRITE, VERIFY, CANCEL };
+
+  void RunWriteTest(RunOption option = WRITE) {
+    base::RunLoop run_loop;
+    quit_closure_ = run_loop.QuitClosure();
+
+    verify_ = (option == VERIFY);
+    cancel_ = (option == CANCEL);
+
+    content::BrowserThread::PostTask(
+        content::BrowserThread::IO, FROM_HERE,
+        base::Bind(&ImageWriterUtilityClientTest::StartWriteTest,
+                   base::Unretained(this)));
+    run_loop.Run();
+
+    EXPECT_TRUE(quit_called_);
+  }
+
+  void RunVerifyTest(RunOption option = VERIFY) {
+    base::RunLoop run_loop;
+    quit_closure_ = run_loop.QuitClosure();
+
+    CHECK_NE(option, WRITE);  // Verify tests do not WRITE.
+    cancel_ = (option == CANCEL);
+
+    content::BrowserThread::PostTask(
+        content::BrowserThread::IO, FROM_HERE,
+        base::Bind(&ImageWriterUtilityClientTest::StartVerifyTest,
+                   base::Unretained(this)));
+    run_loop.Run();
+
+    EXPECT_TRUE(quit_called_);
+  }
+
+  bool success_ = false;

[Sam McNally, 2017/02/02 21:54:17]

These should be private with public getter methods.

[Noel Gordon, 2017/02/03 13:54:56]

Done.

+  std::string error_;
+
+ private:
+  void StartWriteTest() {
+    DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+
+    if (!image_writer_utility_client_)
+      image_writer_utility_client_ = new ImageWriterUtilityClient();
+    success_ = false;
+    progress_ = 0;
+
+    image_writer_utility_client_->Write(
+        base::Bind(&ImageWriterUtilityClientTest::Progress,
+                   base::Unretained(this)),
+        base::Bind(&ImageWriterUtilityClientTest::Success,
+                   base::Unretained(this)),
+        base::Bind(&ImageWriterUtilityClientTest::Failure,
+                   base::Unretained(this)),
+        image_, test_device_);
+  }
+
+  void Progress(int64_t progress) {
+    DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+
+    progress_ = progress;
+    if (!cancel_)
+      return;
+
+    image_writer_utility_client_->Cancel(base::Bind(
+        &ImageWriterUtilityClientTest::Cancelled, base::Unretained(this)));
+  }
+
+  void Success() {
+    DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+
+    EXPECT_EQ(progress_, kTestFileSize);
+    EXPECT_FALSE(cancel_);
+    success_ = !cancel_;
+
+    if (verify_) {
+      StartVerifyTest();
+      return;
+    }
+
+    content::BrowserThread::PostTask(
+        content::BrowserThread::IO, FROM_HERE,
+        base::Bind(&ImageWriterUtilityClientTest::Shutdown,
+                   base::Unretained(this)));
+  }
+
+  void StartVerifyTest() {
+    DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+
+    if (!image_writer_utility_client_)
+      image_writer_utility_client_ = new ImageWriterUtilityClient();
+    success_ = false;
+    progress_ = 0;
+
+    image_writer_utility_client_->Verify(
+        base::Bind(&ImageWriterUtilityClientTest::Progress,
+                   base::Unretained(this)),
+        base::Bind(&ImageWriterUtilityClientTest::Verified,
+                   base::Unretained(this)),
+        base::Bind(&ImageWriterUtilityClientTest::Failure,
+                   base::Unretained(this)),
+        image_, test_device_);
+  }
+
+  void Failure(const std::string& error) {
+    DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+
+    EXPECT_FALSE(error.empty());
+    success_ = false;
+    error_ = error;
+
+    content::BrowserThread::PostTask(
+        content::BrowserThread::IO, FROM_HERE,
+        base::Bind(&ImageWriterUtilityClientTest::Shutdown,
+                   base::Unretained(this)));
+  }
+
+  void Verified() {
+    DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+
+    EXPECT_EQ(progress_, kTestFileSize);
+    EXPECT_FALSE(cancel_);
+    success_ = !cancel_;
+
+    content::BrowserThread::PostTask(
+        content::BrowserThread::IO, FROM_HERE,
+        base::Bind(&ImageWriterUtilityClientTest::Shutdown,
+                   base::Unretained(this)));
+  }
+
+  void Cancelled() {
+    DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+
+    EXPECT_TRUE(cancel_);
+    success_ = cancel_;
+
+    quit_called_ = true;
+    content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
+                                     quit_closure_);
+  }
+
+  void Shutdown() {
+    DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+
+    image_writer_utility_client_->Shutdown();
+
+    quit_called_ = true;
+    content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
+                                     quit_closure_);
+  }
+
+  static void FillFile(const base::FilePath& path, int pattern) {

[Sam McNally, 2017/02/02 21:54:17]

Make this a function in an anonymous namespace.

[Noel Gordon, 2017/02/03 13:54:56]

I'd prefer to leave it as an internal detail of this class. much like CopyFile
from our previous browsertest on out-of-process file patching.

+    std::unique_ptr<char[]> buffer(new char[kTestFileSize]);

[Sam McNally, 2017/02/02 21:54:17]

std::vector<char> buffer(kTestFileSize, pattern);
and make pattern a char.

[Noel Gordon, 2017/02/03 13:54:56]

Ah, ain't std::vector<> all grown-up these days.  Done.
Done.

+    memset(buffer.get(), pattern, kTestFileSize);
+
+    EXPECT_TRUE(base::WriteFile(path, buffer.get(), kTestFileSize));
+  }
+
+  base::ScopedTempDir temp_dir_;
+  base::FilePath test_device_;
+  base::FilePath device_;
+  base::FilePath image_;
+
+  base::Closure quit_closure_;
+  bool quit_called_ = false;
+
+  scoped_refptr<ImageWriterUtilityClient> image_writer_utility_client_;
+  int64_t progress_ = 0;
+  bool verify_ = false;
+  bool cancel_ = false;
+
+  DISALLOW_COPY_AND_ASSIGN(ImageWriterUtilityClientTest);
+};
+
+IN_PROC_BROWSER_TEST_F(ImageWriterUtilityClientTest, WriteNoImage) {
+  RunWriteTest();
+
+  EXPECT_FALSE(success_);
+  EXPECT_FALSE(error_.empty());
+}
+
+IN_PROC_BROWSER_TEST_F(ImageWriterUtilityClientTest, WriteNoDevice) {
+  FillImageFileWithPattern(0);
+
+  RunWriteTest();
+
+  EXPECT_FALSE(success_);
+  EXPECT_FALSE(error_.empty());
+}
+
+IN_PROC_BROWSER_TEST_F(ImageWriterUtilityClientTest, Write) {
+  FillImageFileWithPattern(0x55555555);
+  FillDeviceFileWithPattern(0);
+
+  RunWriteTest();
+
+  EXPECT_TRUE(success_);
+  EXPECT_TRUE(error_.empty());
+}
+
+IN_PROC_BROWSER_TEST_F(ImageWriterUtilityClientTest, WriteVerify) {
+  FillImageFileWithPattern(0x55555555);

[Sam McNally, 2017/02/02 21:54:17]

How about changing the pattern across tests?

[Noel Gordon, 2017/02/03 13:54:56]

Done.

+  FillDeviceFileWithPattern(0);
+
+  RunWriteTest(VERIFY);
+
+  EXPECT_TRUE(success_);
+  EXPECT_TRUE(error_.empty());
+}
+
+IN_PROC_BROWSER_TEST_F(ImageWriterUtilityClientTest, WriteCancel) {
+  FillImageFileWithPattern(0x55555555);
+  FillDeviceFileWithPattern(0);
+
+  RunWriteTest(CANCEL);
+
+  EXPECT_TRUE(success_);
+  EXPECT_TRUE(error_.empty());
+}
+
+IN_PROC_BROWSER_TEST_F(ImageWriterUtilityClientTest, VerifyNoImage) {
+  RunVerifyTest();
+
+  EXPECT_FALSE(success_);
+  EXPECT_FALSE(error_.empty());
+}
+
+IN_PROC_BROWSER_TEST_F(ImageWriterUtilityClientTest, VerifyNoDevice) {
+  FillImageFileWithPattern(0);
+
+  RunVerifyTest();
+
+  EXPECT_FALSE(success_);
+  EXPECT_FALSE(error_.empty());
+}
+
+IN_PROC_BROWSER_TEST_F(ImageWriterUtilityClientTest, VerifyFailure) {
+  FillImageFileWithPattern(0x55555555);
+  FillDeviceFileWithPattern(0);
+
+  RunVerifyTest();
+
+  EXPECT_FALSE(success_);
+  EXPECT_FALSE(error_.empty());
+}
+
+IN_PROC_BROWSER_TEST_F(ImageWriterUtilityClientTest, Verify) {
+  FillImageFileWithPattern(0x55555555);
+  FillDeviceFileWithPattern(0x55555555);
+
+  RunVerifyTest();
+
+  EXPECT_TRUE(success_);
+  EXPECT_TRUE(error_.empty());
+}
+
+IN_PROC_BROWSER_TEST_F(ImageWriterUtilityClientTest, VerifyCancel) {
+  FillImageFileWithPattern(0x55555555);
+  FillDeviceFileWithPattern(0x55555555);
+
+  RunVerifyTest(CANCEL);
+
+  EXPECT_TRUE(success_);
+  EXPECT_TRUE(error_.empty());
+}