Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 266353011: Chromium no longer needs to extract toolchains during runhooks. (Closed)

Created:
6 years, 7 months ago by David Yen
Modified:
6 years, 7 months ago
Reviewers:
bradnelson
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : Delete stale toolchains so we know this actually works #

Patch Set 5 : Do not delete any hidden files/directories #

Patch Set 6 : nacl_integration uses scons so should continue to extract toolchains #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M build/download_nacl_toolchains.py View 1 2 3 4 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
David Yen
6 years, 7 months ago (2014-05-06 22:13:20 UTC) #1
bradnelson
lgtm Commit message probably should begin with a capital.
6 years, 7 months ago (2014-05-06 22:45:26 UTC) #2
David Yen
The CQ bit was checked by dyen@chromium.org
6 years, 7 months ago (2014-05-13 17:16:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dyen@chromium.org/266353011/100001
6 years, 7 months ago (2014-05-13 17:16:52 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 17:50:07 UTC) #5
Message was sent while issue was closed. 
Change committed as 270142

Powered by Google App Engine
This is Rietveld 408576698