Add generateAppForLink function in chrome.management

chrome/browser/extensions/bookmark_app_helper.cc

Index: chrome/browser/extensions/bookmark_app_helper.cc
===================================================================
--- chrome/browser/extensions/bookmark_app_helper.cc	(revision 271412)
+++ chrome/browser/extensions/bookmark_app_helper.cc	(working copy)
@@ -182,6 +182,9 @@
 
   crx_installer_->set_error_on_unsupported_requirements(true);
 
+  if (!contents)
+    return;
+
   // Add urls from the WebApplicationInfo.
   std::vector<GURL> web_app_info_icon_urls;
   for (std::vector<WebApplicationInfo::IconInfo>::const_iterator it =
@@ -203,7 +206,11 @@
 
 void BookmarkAppHelper::Create(const CreateBookmarkAppCallback& callback) {
   callback_ = callback;
-  favicon_downloader_->Start();
+
+  if (favicon_downloader_.get())
+    favicon_downloader_->Start();
+  else
+    OnIconsDownloaded(true, std::map<GURL, std::vector<SkBitmap> >());
 }
 
 void BookmarkAppHelper::OnIconsDownloaded(
@@ -244,6 +251,15 @@
   std::map<int, SkBitmap> resized_bitmaps(
       ConstrainBitmapsToSizes(downloaded_icons, allowed_sizes));
 
+  // Add the existing icon from WebApplicationInfo if there is no resized icon.
+  if (resized_bitmaps.empty() &&
+      web_app_info_.icons.size() &&
+      !web_app_info_.icons[0].data.drawsNothing()) {
+    SkBitmap* icon = &web_app_info_.icons[0].data;

[calamity, 2014/05/27 05:32:12]

Just use a const SkBitmap& here.

[wjywbs, 2014/05/27 06:22:32]

Done.

+    DCHECK_EQ(icon->width(), icon->height());
+    resized_bitmaps[icon->width()] = *icon;
+  }
+

[calamity, 2014/05/27 05:32:12]

It seems a little messy to just take the first icon. I think it's legitimate to
use web_app_info_.icons to fill in any icons sizes that are missing.

You can just add all the valid bitmaps from web_app_info_ to downloaded_icons
above. You should then call web_app_info_.icons.clear() to avoid duplicating a
bitmap.

You should add the bitmaps to the end of downloaded_icons so that downloaded
icons are preferred.

[wjywbs, 2014/05/27 06:22:32]

Done, but can we clear the web_app_info_.icons? It may contains the url of the
icons and empty bitmap. Is the |url| in IconInfo used for sync? Or how about add
all other sizes of the icons that do not exist in |resized_bitmaps|?

[calamity, 2014/05/27 07:18:48]

Clearing the icons should be fine.

The icon URL isn't used for anything at the moment, it's mostly a container to
pass through information into this class.

Icons aren't synced right now. Using the icon URL was considered but there is a
blob sync API in development that looks suitable for syncing icons directly.

Adding to |resized_bitmaps| isn't great because the subsequent code assumes that
only valid icon sizes will be in there. If web_app_info_ for some reason has an
18x18 icon, it should be discarded or resized to 16x16 before use which will
currently happen in ConstrainBitmapsToSizes.

[wjywbs, 2014/05/27 22:20:21]

I added "web_app_info_.icons.clear();".

   // Generate container icons from smaller icons.
   const int kIconSizesToGenerate[] = {extension_misc::EXTENSION_ICON_SMALL,
                                       extension_misc::EXTENSION_ICON_MEDIUM, };