Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: src/objects/literal-objects.cc

Issue 2663513002: [objects.h splitting] Move out ConstantElementsPair and BoileplateDescriptor. (Closed)
Patch Set: moving constant_elements_kind to ast.cc Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects/literal-objects.h ('k') | src/v8.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects/literal-objects.cc
diff --git a/src/objects/literal-objects.cc b/src/objects/literal-objects.cc
new file mode 100644
index 0000000000000000000000000000000000000000..551b03621e72d90aa0a602b176153a5303f6fc26
--- /dev/null
+++ b/src/objects/literal-objects.cc
@@ -0,0 +1,55 @@
+// Copyright 2017 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "src/objects/literal-objects.h"
+
+#include "src/factory.h"
+#include "src/isolate.h"
+#include "src/objects-inl.h"
+
+namespace v8 {
+namespace internal {
+
+Object* BoilerplateDescription::name(int index) const {
+ // get() already checks for out of bounds access, but we do not want to allow
+ // access to the last element, if it is the number of properties.
+ DCHECK_NE(size(), index);
+ return get(2 * index);
+}
+
+Object* BoilerplateDescription::value(int index) const {
+ return get(2 * index + 1);
+}
+
+int BoilerplateDescription::size() const {
+ DCHECK_EQ(0, (length() - (this->has_number_of_properties() ? 1 : 0)) % 2);
+ // Rounding is intended.
+ return length() / 2;
+}
+
+int BoilerplateDescription::backing_store_size() const {
+ if (has_number_of_properties()) {
+ // If present, the last entry contains the number of properties.
+ return Smi::cast(this->get(length() - 1))->value();
+ }
+ // If the number is not given explicitly, we assume there are no
+ // properties with computed names.
+ return size();
+}
+
+void BoilerplateDescription::set_backing_store_size(Isolate* isolate,
+ int backing_store_size) {
+ DCHECK(has_number_of_properties());
+ DCHECK_NE(size(), backing_store_size);
+ Handle<Object> backing_store_size_obj =
+ isolate->factory()->NewNumberFromInt(backing_store_size);
+ set(length() - 1, *backing_store_size_obj);
+}
+
+bool BoilerplateDescription::has_number_of_properties() const {
+ return length() % 2 != 0;
+}
+
+} // namespace internal
+} // namespace v8
« no previous file with comments | « src/objects/literal-objects.h ('k') | src/v8.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698