Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: src/objects.cc

Issue 2663513002: [objects.h splitting] Move out ConstantElementsPair and BoileplateDescriptor. (Closed)
Patch Set: moving constant_elements_kind to ast.cc Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 4542e19293a7b216fc1af216877b17fd8bf8bc13..16e4452d65aa961d0e5788deccc58d63f251abc6 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -9837,46 +9837,6 @@ void FixedArray::CopyTo(int pos, FixedArray* dest, int dest_pos, int len) {
}
}
-Object* BoilerplateDescription::name(int index) const {
- // get() already checks for out of bounds access, but we do not want to allow
- // access to the last element, if it is the number of properties.
- DCHECK_NE(size(), index);
- return get(2 * index);
-}
-
-Object* BoilerplateDescription::value(int index) const {
- return get(2 * index + 1);
-}
-
-int BoilerplateDescription::size() const {
- DCHECK_EQ(0, (length() - (this->has_number_of_properties() ? 1 : 0)) % 2);
- // Rounding is intended.
- return length() / 2;
-}
-
-int BoilerplateDescription::backing_store_size() const {
- if (has_number_of_properties()) {
- // If present, the last entry contains the number of properties.
- return Smi::cast(this->get(length() - 1))->value();
- }
- // If the number is not given explicitly, we assume there are no
- // properties with computed names.
- return size();
-}
-
-void BoilerplateDescription::set_backing_store_size(Isolate* isolate,
- int backing_store_size) {
- DCHECK(has_number_of_properties());
- DCHECK_NE(size(), backing_store_size);
- Handle<Object> backing_store_size_obj =
- isolate->factory()->NewNumberFromInt(backing_store_size);
- set(length() - 1, *backing_store_size_obj);
-}
-
-bool BoilerplateDescription::has_number_of_properties() const {
- return length() % 2 != 0;
-}
-
#ifdef DEBUG
bool FixedArray::IsEqualTo(FixedArray* other) {
if (length() != other->length()) return false;
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698