Account for fasta in subpackage_relationships_test

Account for fasta in subpackage_relationships_test

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/1ec9a02f23695e39b2667f03351b239fef217238

[Paul Berry, 2017-02-01 13:36:16]

paulberry@google.com changed reviewers:
+ ahe@google.com, sigmund@google.com

[ahe, 2017-02-01 13:39:34]

lgtm

Thank you!

[ahe, 2017-02-01 13:40:37]

FYI

https://codereview.chromium.org/2663403002/diff/1/pkg/front_end/test/subpacka...
File pkg/front_end/test/subpackage_relationships_test.dart (right):

https://codereview.chromium.org/2663403002/diff/1/pkg/front_end/test/subpacka...
pkg/front_end/test/subpackage_relationships_test.dart:37: 'lib/src/fasta': new
SubpackageRules(mayImportAnalyzer: true),
I should probably move all analyzer dependencies to lib/src/fasta/analyzer.

[Paul Berry, 2017-02-01 13:44:38]

https://codereview.chromium.org/2663403002/diff/1/pkg/front_end/test/subpacka...
File pkg/front_end/test/subpackage_relationships_test.dart (right):

https://codereview.chromium.org/2663403002/diff/1/pkg/front_end/test/subpacka...
pkg/front_end/test/subpackage_relationships_test.dart:37: 'lib/src/fasta': new
SubpackageRules(mayImportAnalyzer: true),
On 2017/02/01 13:40:37, ahe wrote:
> I should probably move all analyzer dependencies to lib/src/fasta/analyzer.

Do you think, for purposes of the checks done by this test, we should consider
the subdirectories of fasta each as their own subpackage?

[Paul Berry, 2017-02-01 13:47:24]

Description was changed from

==========
Account for fasta in subpackage_relationships_test
==========

to

==========
Account for fasta in subpackage_relationships_test

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1ec9a02f23695e39b2667f03351b239fef217238
==========

[Paul Berry, 2017-02-01 13:47:26]

Committed patchset #1 (id:1) manually as
1ec9a02f23695e39b2667f03351b239fef217238 (presubmit successful).

[ahe, 2017-02-01 13:52:04]

https://codereview.chromium.org/2663403002/diff/1/pkg/front_end/test/subpacka...
File pkg/front_end/test/subpackage_relationships_test.dart (right):

https://codereview.chromium.org/2663403002/diff/1/pkg/front_end/test/subpacka...
pkg/front_end/test/subpackage_relationships_test.dart:37: 'lib/src/fasta': new
SubpackageRules(mayImportAnalyzer: true),
On 2017/02/01 13:44:38, Paul Berry wrote:
> On 2017/02/01 13:40:37, ahe wrote:
> > I should probably move all analyzer dependencies to lib/src/fasta/analyzer.
> 
> Do you think, for purposes of the checks done by this test, we should consider
> the subdirectories of fasta each as their own subpackage?

Yes, that would be nice.