[Android] Add options in the context menu of CCT to open in a new Chrome tab or incoginto tab

chrome/android/java/src/org/chromium/chrome/browser/DefaultBrowserInfo.java

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser;
+
+import android.app.Activity;
+import android.content.Intent;
+import android.content.pm.PackageManager;
+import android.content.pm.ResolveInfo;
+import android.net.Uri;
+import android.os.AsyncTask;
+
+import org.chromium.base.BuildInfo;
+import org.chromium.chrome.R;
+
+import java.util.concurrent.ExecutionException;
+
+/**
+ * A utility class for querying information about the default browser setting.
+ */
+public class DefaultBrowserInfo {
+    private static final String SAMPLE_URL = "https://www.google.com";

[Ted C, 2017/02/14 19:02:00]

I would use the one from cacheIsChromeDefaultBrowser

http://www.madeupdomainforcheck123.com/

www.google.com could potentially be handled by a google app in the future, so it
is safer to use something else IMO.

[ltian, 2017/02/16 05:05:10]

Done.

+
+    /**
+     * @return Title of menu item for opening tab in the default browser.
+     * @param activity The activity to open the menu.
+     * @param isOpenedByChrome Whether the menu is opened by Chrome.
+     * @throws ExecutionException
+     * @throws InterruptedException
+     */
+    public static String getTitleOpenInDefaultBrowser(final Activity activity,
+            final Boolean isOpenedByChrome) throws InterruptedException, ExecutionException {

[Ted C, 2017/02/14 19:02:00]

Why capital B boolean?

Also, do you need Activity here or can you ContextUtils.getApplicationContext?

I would also not say openedByChrome, I would say something like
"forceChromeAsDefault" or something more generic.

[ltian, 2017/02/16 05:05:10]

Done.

+        AsyncTask<Void, Void, String> defaultBrowserFetcher = new AsyncTask<Void, Void, String>() {

[Ted C, 2017/02/14 19:02:00]

Creating an AsyncTask and then calling get on it immediately doesn't provide any
benefit.

You need to add an initialize method to this class (whether it is through the
singleton pattern or just another static method).  Then you need to kick this
off in DeferredStartupHandler like cacheIsChromeDefaultBrowser.

Then in this method, you can just call get on the fetcher (potentially calling
initialize yourself if it hadn't been called yet).  Also, you shouldn't have
this throw exceptions.  I would just catch them and return the default label in
that case.

+            @Override
+            protected String doInBackground(Void... params) {
+                String packageLabel = null;
+                if (isOpenedByChrome) {
+                    // If the Custom Tab was created by Chrome, Chrome should open it.
+                    packageLabel = BuildInfo.getPackageLabel(activity);
+                } else {
+                    // Check if there is a default handler for the Intent.  If so, grab its label.
+                    Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(SAMPLE_URL));
+                    PackageManager pm = activity.getPackageManager();
+                    ResolveInfo info = pm.resolveActivity(intent, 0);
+                    if (info != null && info.match != 0) {
+                        packageLabel = info.loadLabel(pm).toString();
+                    }
+                }
+
+                return packageLabel == null
+                        ? activity.getString(R.string.menu_open_in_product_default)
+                        : activity.getString(R.string.menu_open_in_product, packageLabel);
+            }
+        };
+        defaultBrowserFetcher.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
+        return defaultBrowserFetcher.get();
+    }
+}