Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc

Issue 2663313002: 📰 Merge the has_fetch_more and has_reload actions (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
diff --git a/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc b/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
index 32c7a68a9cb176570f7a37f287a9afb347678e8f..84b83172c3c06ff8e2c1023bb16acc941e47b934 100644
--- a/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
+++ b/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
@@ -588,8 +588,7 @@ TEST_F(RemoteSuggestionsProviderImplTest, CategoryTitle) {
CategoryInfo info_before = service->GetCategoryInfo(articles_category());
ASSERT_THAT(info_before.title(), Not(IsEmpty()));
ASSERT_THAT(info_before.title(), Not(Eq(test_default_title)));
- EXPECT_THAT(info_before.has_more_action(), Eq(true));
- EXPECT_THAT(info_before.has_reload_action(), Eq(true));
+ EXPECT_THAT(info_before.has_fetch_action(), Eq(true));
EXPECT_THAT(info_before.has_view_all_action(), Eq(false));
EXPECT_THAT(info_before.show_if_empty(), Eq(true));
@@ -606,8 +605,7 @@ TEST_F(RemoteSuggestionsProviderImplTest, CategoryTitle) {
CategoryInfo info_with_title = service->GetCategoryInfo(articles_category());
EXPECT_THAT(info_before.title(), Not(Eq(info_with_title.title())));
EXPECT_THAT(test_default_title, Eq(info_with_title.title()));
- EXPECT_THAT(info_before.has_more_action(), Eq(true));
- EXPECT_THAT(info_before.has_reload_action(), Eq(true));
+ EXPECT_THAT(info_before.has_fetch_action(), Eq(true));
EXPECT_THAT(info_before.has_view_all_action(), Eq(false));
EXPECT_THAT(info_before.show_if_empty(), Eq(true));
}
@@ -663,8 +661,7 @@ TEST_F(RemoteSuggestionsProviderImplTest, MultipleCategories) {
TEST_F(RemoteSuggestionsProviderImplTest, ArticleCategoryInfo) {
auto service = MakeSuggestionsProvider();
CategoryInfo article_info = service->GetCategoryInfo(articles_category());
- EXPECT_THAT(article_info.has_more_action(), Eq(true));
- EXPECT_THAT(article_info.has_reload_action(), Eq(true));
+ EXPECT_THAT(article_info.has_fetch_action(), Eq(true));
EXPECT_THAT(article_info.has_view_all_action(), Eq(false));
EXPECT_THAT(article_info.show_if_empty(), Eq(true));
}
@@ -681,8 +678,7 @@ TEST_F(RemoteSuggestionsProviderImplTest, ExperimentalCategoryInfo) {
LoadFromJSONString(service.get(), json_str);
CategoryInfo info = service->GetCategoryInfo(unknown_category());
- EXPECT_THAT(info.has_more_action(), Eq(false));
- EXPECT_THAT(info.has_reload_action(), Eq(false));
+ EXPECT_THAT(info.has_fetch_action(), Eq(false));
EXPECT_THAT(info.has_view_all_action(), Eq(false));
EXPECT_THAT(info.show_if_empty(), Eq(false));
}

Powered by Google App Engine
This is Rietveld 408576698