Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1491)

Unified Diff: components/ntp_snippets/remote/json_request.cc

Issue 2663313002: 📰 Merge the has_fetch_more and has_reload actions (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/json_request.cc
diff --git a/components/ntp_snippets/remote/json_request.cc b/components/ntp_snippets/remote/json_request.cc
index 8e522936d5d79ddb200a36198fd93ebe493e0939..ec52caa7d58b966d67a3df9948f8707371d68b25 100644
--- a/components/ntp_snippets/remote/json_request.cc
+++ b/components/ntp_snippets/remote/json_request.cc
@@ -139,10 +139,7 @@ CategoryInfo BuildArticleCategoryInfo(
: l10n_util::GetStringUTF16(
IDS_NTP_ARTICLE_SUGGESTIONS_SECTION_HEADER),
ContentSuggestionsCardLayout::FULL_CARD,
- // TODO(dgn): merge has_more_action and has_reload_action when we remove
- // the kFetchMoreFeature flag. See https://crbug.com/667752
- /*has_more_action=*/true,
- /*has_reload_action=*/true,
+ /*has_fetch_action=*/true,
/*has_view_all_action=*/false,
/*show_if_empty=*/true,
l10n_util::GetStringUTF16(IDS_NTP_ARTICLE_SUGGESTIONS_SECTION_EMPTY));
@@ -152,10 +149,7 @@ CategoryInfo BuildRemoteCategoryInfo(const base::string16& title,
bool allow_fetching_more_results) {
return CategoryInfo(
title, ContentSuggestionsCardLayout::FULL_CARD,
- // TODO(dgn): merge has_more_action and has_reload_action when we remove
- // the kFetchMoreFeature flag. See https://crbug.com/667752
- /*has_more_action=*/allow_fetching_more_results,
- /*has_reload_action=*/allow_fetching_more_results,
+ /*has_fetch_action=*/allow_fetching_more_results,
/*has_view_all_action=*/false,
/*show_if_empty=*/false,
// TODO(tschumann): The message for no-articles is likely wrong

Powered by Google App Engine
This is Rietveld 408576698