Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4237)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

Issue 2663313002: 📰 Merge the has_fetch_more and has_reload actions (Closed)
Patch Set: fix tests pt 2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
index 52125c767656f19f3835df1f30e20824486a8182..ddaa1dc55c0317814f26333b3a71e786a8fbff73 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
@@ -681,30 +681,29 @@ public void testChangeNotifications() {
// 0 | Above-the-fold
// 1 | Header
// 2-4 | Sugg*3
- // 5 | Footer
- // 6 | Spacer
+ // 5 | Action
+ // 6 | Footer
+ // 7 | Spacer
// Dismiss the second suggestion of the second section.
mAdapter.dismissItem(3, itemDismissedCallback);
verify(itemDismissedCallback).onResult(anyString());
verify(dataObserver).onItemRangeRemoved(3, 1);
- verify(dataObserver).onItemRangeChanged(5, 1, null);
+ verify(dataObserver).onItemRangeChanged(6, 1, null);
// Make sure the call with the updated position works properly.
mAdapter.dismissItem(3, itemDismissedCallback);
verify(itemDismissedCallback, times(2)).onResult(anyString());
verify(dataObserver, times(2)).onItemRangeRemoved(3, 1);
- verify(dataObserver).onItemRangeChanged(4, 1, null);
+ verify(dataObserver).onItemRangeChanged(5, 1, null);
// Dismiss the last suggestion in the section. We should now show the status card.
reset(dataObserver);
mAdapter.dismissItem(2, itemDismissedCallback);
verify(itemDismissedCallback, times(3)).onResult(anyString());
verify(dataObserver).onItemRangeRemoved(2, 1); // Suggestion removed
- verify(dataObserver).onItemRangeChanged(3, 1, null); // Spacer refresh
- verify(dataObserver).onItemRangeInserted(2, 1); // Status card added
verify(dataObserver).onItemRangeChanged(4, 1, null); // Spacer refresh
- verify(dataObserver).onItemRangeInserted(3, 1); // Action item added
+ verify(dataObserver).onItemRangeInserted(2, 1); // Status card added
verify(dataObserver).onItemRangeChanged(5, 1, null); // Spacer refresh
// Adapter content:
@@ -724,9 +723,8 @@ public void testChangeNotifications() {
createDummySuggestions(newSuggestionCount, KnownCategories.ARTICLES));
verify(dataObserver).onItemRangeInserted(2, newSuggestionCount);
verify(dataObserver).onItemRangeChanged(5 + newSuggestionCount, 1, null); // Spacer refresh
- verify(dataObserver, times(2)).onItemRangeRemoved(2 + newSuggestionCount, 1);
+ verify(dataObserver).onItemRangeRemoved(2 + newSuggestionCount, 1);
verify(dataObserver).onItemRangeChanged(4 + newSuggestionCount, 1, null); // Spacer refresh
- verify(dataObserver).onItemRangeChanged(3 + newSuggestionCount, 1, null); // Spacer refresh
// Adapter content:
// Idx | Item
@@ -734,8 +732,9 @@ public void testChangeNotifications() {
// 0 | Above-the-fold
// 1 | Header
// 2-8 | Sugg*7
- // 9 | Footer
- // 10 | Spacer
+ // 9 | Action
+ // 10 | Footer
+ // 11 | Spacer
reset(dataObserver);
suggestionsSource.setSuggestionsForCategory(
@@ -743,10 +742,8 @@ public void testChangeNotifications() {
mAdapter.getSectionListForTesting().onCategoryStatusChanged(
KnownCategories.ARTICLES, CategoryStatus.SIGNED_OUT);
verify(dataObserver).onItemRangeRemoved(2, newSuggestionCount);
- verify(dataObserver).onItemRangeChanged(3, 1, null); // Spacer refresh
- verify(dataObserver).onItemRangeInserted(2, 1); // Status card added
verify(dataObserver).onItemRangeChanged(4, 1, null); // Spacer refresh
- verify(dataObserver).onItemRangeInserted(3, 1); // Action item added
+ verify(dataObserver).onItemRangeInserted(2, 1); // Status card added
verify(dataObserver).onItemRangeChanged(5, 1, null); // Spacer refresh
}

Powered by Google App Engine
This is Rietveld 408576698