chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java - Issue 2663313002: 📰 Merge the has_fetch_more and has_reload actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2663313002: 📰 Merge the has_fetch_more and has_reload actions (Closed)

Patch Set: fix tests pt 2 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java » ('j') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

index 87e5e0039afed783181ff92eb48ffec379023e5a..2f5a93a188079b1a9ee53a19b656f5faf69f4f82 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

@@ -286,10 +286,10 @@ private static void setRecentTabDataForSuggestion(

@CalledByNative

private static SuggestionsCategoryInfo createSuggestionsCategoryInfo(int category, String title,

- int cardLayout, boolean hasMoreAction, boolean hasReloadAction,

- boolean hasViewAllAction, boolean showIfEmpty, String noSuggestionsMessage) {

- return new SuggestionsCategoryInfo(category, title, cardLayout, hasMoreAction,

- hasReloadAction, hasViewAllAction, showIfEmpty, noSuggestionsMessage);

+ int cardLayout, boolean hasFetchAction, boolean hasViewAllAction, boolean showIfEmpty,

+ String noSuggestionsMessage) {

+ return new SuggestionsCategoryInfo(category, title, cardLayout, hasFetchAction,

+ hasViewAllAction, showIfEmpty, noSuggestionsMessage);

}

@CalledByNative