Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: components/image_fetcher/ios/ios_image_data_fetcher_wrapper_unittest.mm

Issue 2663213002: Create the IOSImageDataFetcherWrapper (Closed)
Patch Set: Address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #import "components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h"
6
7 #import <UIKit/UIKit.h>
8
9 #include "base/ios/ios_util.h"
10 #include "base/mac/scoped_block.h"
11 #include "base/macros.h"
12 #include "base/memory/ptr_util.h"
13 #include "base/memory/ref_counted.h"
14 #include "base/run_loop.h"
15 #include "base/threading/thread.h"
16 #include "base/threading/thread_task_runner_handle.h"
17 #include "build/build_config.h"
18 #import "ios/web/public/image_fetcher/webp_decoder.h"
19 #include "net/http/http_response_headers.h"
20 #include "net/url_request/test_url_fetcher_factory.h"
21 #include "net/url_request/url_fetcher_delegate.h"
22 #include "net/url_request/url_request_test_util.h"
23 #include "testing/gtest/include/gtest/gtest.h"
24 #include "testing/platform_test.h"
25
26 #if !defined(__has_feature) || !__has_feature(objc_arc)
27 #error "This file requires ARC support."
28 #endif
29
30 namespace {
31
32 const unsigned char kJPGImage[] = {
33 255, 216, 255, 224, 0, 16, 74, 70, 73, 70, 0, 1, 1, 1, 0,
34 72, 0, 72, 0, 0, 255, 254, 0, 19, 67, 114, 101, 97, 116, 101,
35 100, 32, 119, 105, 116, 104, 32, 71, 73, 77, 80, 255, 219, 0, 67,
36 0, 5, 3, 4, 4, 4, 3, 5, 4, 4, 4, 5, 5, 5, 6,
37 7, 12, 8, 7, 7, 7, 7, 15, 11, 11, 9, 12, 17, 15, 18,
38 18, 17, 15, 17, 17, 19, 22, 28, 23, 19, 20, 26, 21, 17, 17,
39 24, 33, 24, 26, 29, 29, 31, 31, 31, 19, 23, 34, 36, 34, 30,
40 36, 28, 30, 31, 30, 255, 219, 0, 67, 1, 5, 5, 5, 7, 6,
41 7, 14, 8, 8, 14, 30, 20, 17, 20, 30, 30, 30, 30, 30, 30,
42 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30,
43 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30,
44 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 255,
45 192, 0, 17, 8, 0, 1, 0, 1, 3, 1, 34, 0, 2, 17, 1,
46 3, 17, 1, 255, 196, 0, 21, 0, 1, 1, 0, 0, 0, 0, 0,
47 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 8, 255, 196, 0, 20,
48 16, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
49 0, 0, 0, 255, 196, 0, 20, 1, 1, 0, 0, 0, 0, 0, 0,
50 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 255, 196, 0, 20, 17,
51 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
52 0, 0, 255, 218, 0, 12, 3, 1, 0, 2, 17, 3, 17, 0, 63,
53 0, 178, 192, 7, 255, 217,
54 };
55
56 const unsigned char kPNGImage[] = {
57 137, 80, 78, 71, 13, 10, 26, 10, 0, 0, 0, 13, 73, 72, 68,
58 82, 0, 0, 0, 1, 0, 0, 0, 1, 1, 0, 0, 0, 0, 55,
59 110, 249, 36, 0, 0, 0, 2, 98, 75, 71, 68, 0, 1, 221, 138,
60 19, 164, 0, 0, 0, 9, 112, 72, 89, 115, 0, 0, 11, 18, 0,
61 0, 11, 18, 1, 210, 221, 126, 252, 0, 0, 0, 9, 118, 112, 65,
62 103, 0, 0, 0, 1, 0, 0, 0, 1, 0, 199, 149, 95, 237, 0,
63 0, 0, 10, 73, 68, 65, 84, 8, 215, 99, 104, 0, 0, 0, 130,
64 0, 129, 221, 67, 106, 244, 0, 0, 0, 25, 116, 69, 88, 116, 99,
65 111, 109, 109, 101, 110, 116, 0, 67, 114, 101, 97, 116, 101, 100, 32,
66 119, 105, 116, 104, 32, 71, 73, 77, 80, 231, 175, 64, 203, 0, 0,
67 0, 37, 116, 69, 88, 116, 100, 97, 116, 101, 58, 99, 114, 101, 97,
68 116, 101, 0, 50, 48, 49, 49, 45, 48, 54, 45, 50, 50, 84, 49,
69 54, 58, 49, 54, 58, 52, 54, 43, 48, 50, 58, 48, 48, 31, 248,
70 231, 223, 0, 0, 0, 37, 116, 69, 88, 116, 100, 97, 116, 101, 58,
71 109, 111, 100, 105, 102, 121, 0, 50, 48, 49, 49, 45, 48, 54, 45,
72 50, 50, 84, 49, 54, 58, 49, 54, 58, 52, 54, 43, 48, 50, 58,
73 48, 48, 110, 165, 95, 99, 0, 0, 0, 17, 116, 69, 88, 116, 106,
74 112, 101, 103, 58, 99, 111, 108, 111, 114, 115, 112, 97, 99, 101, 0,
75 50, 44, 117, 85, 159, 0, 0, 0, 32, 116, 69, 88, 116, 106, 112,
76 101, 103, 58, 115, 97, 109, 112, 108, 105, 110, 103, 45, 102, 97, 99,
77 116, 111, 114, 0, 50, 120, 50, 44, 49, 120, 49, 44, 49, 120, 49,
78 73, 250, 166, 180, 0, 0, 0, 0, 73, 69, 78, 68, 174, 66, 96,
79 130,
80 };
81
82 const unsigned char kWEBPImage[] = {
83 82, 73, 70, 70, 74, 0, 0, 0, 87, 69, 66, 80, 86, 80, 56, 88, 10,
84 0, 0, 0, 16, 0, 0, 0, 0, 0, 0, 0, 0, 0, 65, 76, 80, 72,
85 12, 0, 0, 0, 1, 7, 16, 17, 253, 15, 68, 68, 255, 3, 0, 0, 86,
86 80, 56, 32, 24, 0, 0, 0, 48, 1, 0, 157, 1, 42, 1, 0, 1, 0,
87 3, 0, 52, 37, 164, 0, 3, 112, 0, 254, 251, 253, 80, 0,
88 };
89
90 const char kTestUrl[] = "http://www.img.com";
91
92 const char kWEBPHeaderResponse[] =
93 "HTTP/1.1 200 OK\0Content-type: image/webp\0\0";
94
95 class WebpDecoderDelegate : public webp_transcode::WebpDecoder::Delegate {
sdefresne 2017/02/02 10:42:05 nit: please add a TODO() to refactor this with the
gambard 2017/02/02 11:57:02 Done.
96 public:
97 WebpDecoderDelegate() = default;
98 NSData* data() const { return decoded_image_; }
99
100 void OnFinishedDecoding(bool success) override {}
101 void SetImageFeatures(
102 size_t total_size,
103 webp_transcode::WebpDecoder::DecodedImageFormat format) override {
104 decoded_image_ = [[NSMutableData alloc] initWithCapacity:total_size];
105 }
106 void OnDataDecoded(NSData* data) override {
107 [decoded_image_ appendData:data];
108 }
109
110 private:
111 ~WebpDecoderDelegate() override {}
112 NSMutableData* decoded_image_;
113
114 DISALLOW_COPY_AND_ASSIGN(WebpDecoderDelegate);
115 };
116
117 // Returns a NSData object containing the decoded image.
118 NSData* DecodedWebpImage() {
119 scoped_refptr<WebpDecoderDelegate> delegate(new WebpDecoderDelegate);
120 scoped_refptr<webp_transcode::WebpDecoder> decoder(
121 new webp_transcode::WebpDecoder(delegate.get()));
122 decoder->OnDataReceived([NSData
123 dataWithBytes:reinterpret_cast<const char*>(kWEBPImage)
124 length:sizeof(kWEBPImage)]);
125 return delegate->data();
126 }
127
128 } // namespace
129
130 namespace image_fetcher {
131
132 class IOSImageDataFetcherWrapperTest : public PlatformTest {
133 protected:
134 IOSImageDataFetcherWrapperTest()
135 : callback_([^(NSData* data) {
136 result_data_ = data;
137 result_ = [UIImage imageWithData:data];
138 called_ = true;
139 } copy]) {
140 image_fetcher_ = base::MakeUnique<IOSImageDataFetcherWrapper>(
141 new net::TestURLRequestContextGetter(message_loop_.task_runner()),
142 message_loop_.task_runner());
143 }
144
145 net::TestURLFetcher* SetupFetcher() {
146 image_fetcher_->FetchImageDataWebpDecoded(GURL(kTestUrl), callback_);
147 EXPECT_EQ(nil, result_);
148 EXPECT_EQ(false, called_);
149 net::TestURLFetcher* fetcher = factory_.GetFetcherByID(0);
150 DCHECK(fetcher);
151 DCHECK(fetcher->delegate());
152 return fetcher;
153 }
154
155 // Message loop for the main test thread.
156 base::MessageLoop message_loop_;
157
158 base::mac::ScopedBlock<IOSImageDataFetcherCallback> callback_;
159 net::TestURLFetcherFactory factory_;
160 std::unique_ptr<IOSImageDataFetcherWrapper> image_fetcher_;
161 NSData* result_data_ = nil;
162 UIImage* result_ = nil;
163 bool called_ = false;
164
165 private:
166 DISALLOW_COPY_AND_ASSIGN(IOSImageDataFetcherWrapperTest);
167 };
168
169 TEST_F(IOSImageDataFetcherWrapperTest, TestError) {
170 net::TestURLFetcher* fetcher = SetupFetcher();
171 fetcher->set_response_code(404);
172 fetcher->delegate()->OnURLFetchComplete(fetcher);
173 EXPECT_EQ(nil, result_);
174 EXPECT_TRUE(called_);
175 }
176
177 TEST_F(IOSImageDataFetcherWrapperTest, TestJpg) {
178 net::TestURLFetcher* fetcher = SetupFetcher();
179 fetcher->set_response_code(200);
180 fetcher->SetResponseString(
181 std::string(reinterpret_cast<const char*>(kJPGImage), sizeof(kJPGImage)));
182 fetcher->delegate()->OnURLFetchComplete(fetcher);
183 EXPECT_NE(nil, result_);
184 EXPECT_TRUE(called_);
185 }
186
187 TEST_F(IOSImageDataFetcherWrapperTest, TestPng) {
188 net::TestURLFetcher* fetcher = SetupFetcher();
189 fetcher->set_response_code(200);
190 fetcher->SetResponseString(
191 std::string(reinterpret_cast<const char*>(kPNGImage), sizeof(kPNGImage)));
192 fetcher->delegate()->OnURLFetchComplete(fetcher);
193 EXPECT_NE(nil, result_);
194 EXPECT_TRUE(called_);
195 }
196
197 TEST_F(IOSImageDataFetcherWrapperTest, TestGoodWebP) {
198 net::TestURLFetcher* fetcher = SetupFetcher();
199 fetcher->set_response_code(200);
200 fetcher->SetResponseString(std::string(
201 reinterpret_cast<const char*>(kWEBPImage), sizeof(kWEBPImage)));
202 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders(
203 std::string(kWEBPHeaderResponse, arraysize(kWEBPHeaderResponse))));
204 fetcher->set_response_headers(headers);
205 fetcher->delegate()->OnURLFetchComplete(fetcher);
206 base::RunLoop().RunUntilIdle();
207 EXPECT_NE(nil, result_);
208 EXPECT_TRUE(called_);
209 }
210
211 TEST_F(IOSImageDataFetcherWrapperTest, TestGoodWebPNoHeader) {
212 net::TestURLFetcher* fetcher = SetupFetcher();
213 fetcher->set_response_code(200);
214 fetcher->SetResponseString(std::string(
215 reinterpret_cast<const char*>(kWEBPImage), sizeof(kWEBPImage)));
216 fetcher->delegate()->OnURLFetchComplete(fetcher);
217 base::RunLoop().RunUntilIdle();
218 EXPECT_TRUE([DecodedWebpImage() isEqualToData:result_data_]);
219 EXPECT_TRUE(called_);
220 }
221
222 TEST_F(IOSImageDataFetcherWrapperTest, TestBadWebP) {
223 net::TestURLFetcher* fetcher = SetupFetcher();
224 fetcher->set_response_code(200);
225 fetcher->SetResponseString("This is not a valid WebP image");
226 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders(
227 std::string(kWEBPHeaderResponse, arraysize(kWEBPHeaderResponse))));
228 fetcher->set_response_headers(headers);
229 fetcher->delegate()->OnURLFetchComplete(fetcher);
230 base::RunLoop().RunUntilIdle();
231 EXPECT_EQ(nil, result_);
232 EXPECT_TRUE(called_);
233 }
234
235 TEST_F(IOSImageDataFetcherWrapperTest, DeleteDuringWebPDecoding) {
236 net::TestURLFetcher* fetcher = SetupFetcher();
237 fetcher->set_response_code(200);
238 fetcher->SetResponseString(std::string(
239 reinterpret_cast<const char*>(kWEBPImage), sizeof(kWEBPImage)));
240 fetcher->delegate()->OnURLFetchComplete(fetcher);
241 // Delete the image fetcher, and check that the callback is called.
242 image_fetcher_.reset();
243 base::RunLoop().RunUntilIdle();
244 EXPECT_TRUE([DecodedWebpImage() isEqualToData:result_data_]);
245 EXPECT_TRUE(called_);
246 }
247
248 TEST_F(IOSImageDataFetcherWrapperTest, TestCallbacksNotCalledDuringDeletion) {
249 image_fetcher_->FetchImageDataWebpDecoded(GURL(kTestUrl), callback_);
250 image_fetcher_.reset();
251 EXPECT_FALSE(called_);
252 }
253
254 } // namespace image_fetcher
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698