components/image_fetcher/ios/BUILD.gn - Issue 2663213002: Create the IOSImageDataFetcherWrapper

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/image_fetcher/ios/BUILD.gn

Issue 2663213002: Create the IOSImageDataFetcherWrapper (Closed)

Patch Set: Address comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("ios") {

	6 configs += [ "//build/config/compiler:enable_arc" ]
	sdefresne 2017/02/02 10:42:05 nit: please move the "configs" line at the bottom nit: please move the "configs" line at the bottom of the source_set declaration (I know that the declaration added by the conversion script are at the top, but I think they are better at the end and plan to move them all once the conversion is over) gambard 2017/02/02 11:57:02 Done. Show quoted text On 2017/02/02 10:42:05, sdefresne wrote: > nit: please move the "configs" line at the bottom of the source_set declaration > (I know that the declaration added by the conversion script are at the top, but > I think they are better at the end and plan to move them all once the conversion > is over) Done.
	7 sources = [

	8 "ios_image_data_fetcher_wrapper.h",

	9 "ios_image_data_fetcher_wrapper.mm",

	10 ]

	11 deps = [

	12 "//base",

	13 "//components/image_fetcher",

	14 "//ios/web/public/image_fetcher",

	15 "//net",

	16 ]

	17 }

	18

	19 source_set("unit_tests") {

	20 configs += [ "//build/config/compiler:enable_arc" ]
	sdefresne 2017/02/02 10:42:05 ditto ditto gambard 2017/02/02 11:57:02 Done. Show quoted text On 2017/02/02 10:42:05, sdefresne wrote: > ditto Done.
	21 testonly = true

	22 sources = [

	23 "ios_image_data_fetcher_wrapper_unittest.mm",

	24 ]

	25 deps = [

	26 ":ios",

	27 "//base",

	28 "//ios/web/public/image_fetcher",

	29 "//net",

	30 "//net:test_support",

	31 "//testing/gmock",

	32 "//testing/gtest",

	33 ]

	34 }

OLD	NEW

« no previous file with comments | « components/BUILD.gn ('k') | components/image_fetcher/ios/DEPS » ('j') | components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h » ('J')