OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2011 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #import "components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h" | |
6 | |
7 #import <UIKit/UIKit.h> | |
8 | |
9 #include "base/ios/ios_util.h" | |
10 #include "base/mac/scoped_block.h" | |
11 #include "base/macros.h" | |
12 #include "base/memory/ptr_util.h" | |
13 #include "base/memory/ref_counted.h" | |
14 #include "base/run_loop.h" | |
15 #include "base/threading/thread.h" | |
16 #include "base/threading/thread_task_runner_handle.h" | |
17 #include "build/build_config.h" | |
18 #import "ios/web/public/image_fetcher/webp_decoder.h" | |
19 #include "net/http/http_response_headers.h" | |
20 #include "net/url_request/test_url_fetcher_factory.h" | |
21 #include "net/url_request/url_fetcher_delegate.h" | |
22 #include "net/url_request/url_request_test_util.h" | |
23 #include "testing/gtest/include/gtest/gtest.h" | |
24 #include "testing/platform_test.h" | |
25 | |
sdefresne
2017/02/01 09:43:44
I think this file is compiled with ARC (otherwise
gambard
2017/02/02 10:03:47
Done.
| |
26 namespace { | |
27 | |
28 static unsigned char kJPGImage[] = { | |
sdefresne
2017/02/01 09:43:44
"static" is not necessary here, but you need "cons
gambard
2017/02/02 10:03:47
Done.
| |
29 255, 216, 255, 224, 0, 16, 74, 70, 73, 70, 0, 1, 1, 1, 0, | |
30 72, 0, 72, 0, 0, 255, 254, 0, 19, 67, 114, 101, 97, 116, 101, | |
31 100, 32, 119, 105, 116, 104, 32, 71, 73, 77, 80, 255, 219, 0, 67, | |
32 0, 5, 3, 4, 4, 4, 3, 5, 4, 4, 4, 5, 5, 5, 6, | |
33 7, 12, 8, 7, 7, 7, 7, 15, 11, 11, 9, 12, 17, 15, 18, | |
34 18, 17, 15, 17, 17, 19, 22, 28, 23, 19, 20, 26, 21, 17, 17, | |
35 24, 33, 24, 26, 29, 29, 31, 31, 31, 19, 23, 34, 36, 34, 30, | |
36 36, 28, 30, 31, 30, 255, 219, 0, 67, 1, 5, 5, 5, 7, 6, | |
37 7, 14, 8, 8, 14, 30, 20, 17, 20, 30, 30, 30, 30, 30, 30, | |
38 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, | |
39 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, | |
40 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 255, | |
41 192, 0, 17, 8, 0, 1, 0, 1, 3, 1, 34, 0, 2, 17, 1, | |
42 3, 17, 1, 255, 196, 0, 21, 0, 1, 1, 0, 0, 0, 0, 0, | |
43 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 8, 255, 196, 0, 20, | |
44 16, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, | |
45 0, 0, 0, 255, 196, 0, 20, 1, 1, 0, 0, 0, 0, 0, 0, | |
46 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 255, 196, 0, 20, 17, | |
47 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, | |
48 0, 0, 255, 218, 0, 12, 3, 1, 0, 2, 17, 3, 17, 0, 63, | |
49 0, 178, 192, 7, 255, 217}; | |
sdefresne
2017/02/01 09:43:45
nit: use a trailing comma in the array definition
gambard
2017/02/02 10:03:47
Done.
| |
50 | |
51 static unsigned char kPNGImage[] = { | |
sdefresne
2017/02/01 09:43:45
ditto
gambard
2017/02/02 10:03:46
Done.
| |
52 137, 80, 78, 71, 13, 10, 26, 10, 0, 0, 0, 13, 73, 72, 68, | |
53 82, 0, 0, 0, 1, 0, 0, 0, 1, 1, 0, 0, 0, 0, 55, | |
54 110, 249, 36, 0, 0, 0, 2, 98, 75, 71, 68, 0, 1, 221, 138, | |
55 19, 164, 0, 0, 0, 9, 112, 72, 89, 115, 0, 0, 11, 18, 0, | |
56 0, 11, 18, 1, 210, 221, 126, 252, 0, 0, 0, 9, 118, 112, 65, | |
57 103, 0, 0, 0, 1, 0, 0, 0, 1, 0, 199, 149, 95, 237, 0, | |
58 0, 0, 10, 73, 68, 65, 84, 8, 215, 99, 104, 0, 0, 0, 130, | |
59 0, 129, 221, 67, 106, 244, 0, 0, 0, 25, 116, 69, 88, 116, 99, | |
60 111, 109, 109, 101, 110, 116, 0, 67, 114, 101, 97, 116, 101, 100, 32, | |
61 119, 105, 116, 104, 32, 71, 73, 77, 80, 231, 175, 64, 203, 0, 0, | |
62 0, 37, 116, 69, 88, 116, 100, 97, 116, 101, 58, 99, 114, 101, 97, | |
63 116, 101, 0, 50, 48, 49, 49, 45, 48, 54, 45, 50, 50, 84, 49, | |
64 54, 58, 49, 54, 58, 52, 54, 43, 48, 50, 58, 48, 48, 31, 248, | |
65 231, 223, 0, 0, 0, 37, 116, 69, 88, 116, 100, 97, 116, 101, 58, | |
66 109, 111, 100, 105, 102, 121, 0, 50, 48, 49, 49, 45, 48, 54, 45, | |
67 50, 50, 84, 49, 54, 58, 49, 54, 58, 52, 54, 43, 48, 50, 58, | |
68 48, 48, 110, 165, 95, 99, 0, 0, 0, 17, 116, 69, 88, 116, 106, | |
69 112, 101, 103, 58, 99, 111, 108, 111, 114, 115, 112, 97, 99, 101, 0, | |
70 50, 44, 117, 85, 159, 0, 0, 0, 32, 116, 69, 88, 116, 106, 112, | |
71 101, 103, 58, 115, 97, 109, 112, 108, 105, 110, 103, 45, 102, 97, 99, | |
72 116, 111, 114, 0, 50, 120, 50, 44, 49, 120, 49, 44, 49, 120, 49, | |
73 73, 250, 166, 180, 0, 0, 0, 0, 73, 69, 78, 68, 174, 66, 96, | |
74 130}; | |
sdefresne
2017/02/01 09:43:45
ditto
gambard
2017/02/02 10:03:47
Done.
| |
75 | |
76 static unsigned char kWEBPImage[] = { | |
sdefresne
2017/02/01 09:43:45
ditto
gambard
2017/02/02 10:03:47
Done.
| |
77 82, 73, 70, 70, 74, 0, 0, 0, 87, 69, 66, 80, 86, 80, 56, 88, 10, | |
78 0, 0, 0, 16, 0, 0, 0, 0, 0, 0, 0, 0, 0, 65, 76, 80, 72, | |
79 12, 0, 0, 0, 1, 7, 16, 17, 253, 15, 68, 68, 255, 3, 0, 0, 86, | |
80 80, 56, 32, 24, 0, 0, 0, 48, 1, 0, 157, 1, 42, 1, 0, 1, 0, | |
81 3, 0, 52, 37, 164, 0, 3, 112, 0, 254, 251, 253, 80, 0}; | |
sdefresne
2017/02/01 09:43:44
ditto
gambard
2017/02/02 10:03:47
Done.
| |
82 | |
83 static const char kTestUrl[] = "http://www.img.com"; | |
sdefresne
2017/02/01 09:43:44
"static" is not necessary here
gambard
2017/02/02 10:03:47
Done.
| |
84 | |
85 static const char kWEBPHeaderResponse[] = | |
sdefresne
2017/02/01 09:43:44
ditto
gambard
2017/02/02 10:03:47
Done.
| |
86 "HTTP/1.1 200 OK\0Content-type: image/webp\0\0"; | |
87 | |
88 class WebpDecoderDelegate : public webp_transcode::WebpDecoder::Delegate { | |
sdefresne
2017/02/01 09:43:45
This code looks like it is copy-n-pasted from the
gambard
2017/02/02 10:03:47
Yes, but it is also shared with other classes. I w
| |
89 public: | |
90 NSData* data() const { return decoded_image_; } | |
91 | |
92 void OnFinishedDecoding(bool success) override {} | |
93 void SetImageFeatures( | |
94 size_t total_size, | |
95 webp_transcode::WebpDecoder::DecodedImageFormat format) override { | |
96 decoded_image_ = [[NSMutableData alloc] initWithCapacity:total_size]; | |
97 } | |
98 void OnDataDecoded(NSData* data) override { | |
99 [decoded_image_ appendData:data]; | |
100 } | |
101 | |
102 private: | |
103 ~WebpDecoderDelegate() override {} | |
104 NSMutableData* decoded_image_; | |
105 }; | |
106 | |
107 // Returns a NSData object containing the decoded image. | |
108 NSData* DecodedWebpImage() { | |
109 scoped_refptr<WebpDecoderDelegate> delegate(new WebpDecoderDelegate); | |
110 scoped_refptr<webp_transcode::WebpDecoder> decoder( | |
111 new webp_transcode::WebpDecoder(delegate.get())); | |
112 decoder->OnDataReceived( | |
113 [NSData dataWithBytes:(char*)kWEBPImage length:sizeof(kWEBPImage)]); | |
114 return delegate->data(); | |
115 } | |
116 | |
117 } // namespace | |
118 | |
119 namespace image_fetcher { | |
120 | |
121 class IOSImageDataFetcherWrapperTest : public PlatformTest { | |
122 protected: | |
123 IOSImageDataFetcherWrapperTest() | |
124 : worker_thread_("TestThread"), callback_([^(NSData* data) { | |
125 result_data_ = data; | |
126 result_ = [UIImage imageWithData:data]; | |
127 called_ = true; | |
128 } copy]) { | |
129 worker_thread_.Start(); | |
130 | |
131 image_fetcher_ = base::MakeUnique<IOSImageDataFetcherWrapper>( | |
132 new net::TestURLRequestContextGetter( | |
133 base::ThreadTaskRunnerHandle::Get()), | |
134 worker_thread_.task_runner()); | |
135 } | |
136 | |
137 net::TestURLFetcher* SetupFetcher() { | |
138 image_fetcher_->FetchImageDataWebpDecoded(GURL(kTestUrl), callback_); | |
139 EXPECT_EQ(nil, result_); | |
140 EXPECT_EQ(false, called_); | |
141 net::TestURLFetcher* fetcher = factory_.GetFetcherByID(0); | |
142 DCHECK(fetcher); | |
143 DCHECK(fetcher->delegate()); | |
144 return fetcher; | |
145 } | |
146 | |
147 // Message loop for the main test thread. | |
148 base::MessageLoop loop_; | |
149 | |
150 // Worker thread used for ImageFetcher's asynchronous work. | |
151 base::Thread worker_thread_; | |
sdefresne
2017/02/01 09:43:45
I don't think the Thread is necessary here. Can yo
gambard
2017/02/02 10:03:47
Done.
| |
152 | |
153 base::mac::ScopedBlock<IOSImageDataFetcherCallback> callback_; | |
154 net::TestURLFetcherFactory factory_; | |
155 std::unique_ptr<IOSImageDataFetcherWrapper> image_fetcher_; | |
156 NSData* result_data_ = nil; | |
157 UIImage* result_ = nil; | |
158 bool called_ = false; | |
159 | |
160 private: | |
161 DISALLOW_COPY_AND_ASSIGN(IOSImageDataFetcherWrapperTest); | |
162 }; | |
163 | |
164 TEST_F(IOSImageDataFetcherWrapperTest, TestError) { | |
165 net::TestURLFetcher* fetcher = SetupFetcher(); | |
166 fetcher->set_response_code(404); | |
167 fetcher->delegate()->OnURLFetchComplete(fetcher); | |
168 EXPECT_EQ(nil, result_); | |
169 EXPECT_TRUE(called_); | |
170 } | |
171 | |
172 TEST_F(IOSImageDataFetcherWrapperTest, TestJpg) { | |
173 net::TestURLFetcher* fetcher = SetupFetcher(); | |
174 fetcher->set_response_code(200); | |
175 fetcher->SetResponseString(std::string((char*)kJPGImage, sizeof(kJPGImage))); | |
sdefresne
2017/02/01 09:43:45
C style cast are forbidden according to the style
gambard
2017/02/02 10:03:47
Done.
Changed to reinterpret_cast because static_c
| |
176 fetcher->delegate()->OnURLFetchComplete(fetcher); | |
177 EXPECT_NE(nil, result_); | |
178 EXPECT_TRUE(called_); | |
179 } | |
180 | |
181 TEST_F(IOSImageDataFetcherWrapperTest, TestPng) { | |
182 net::TestURLFetcher* fetcher = SetupFetcher(); | |
183 fetcher->set_response_code(200); | |
184 fetcher->SetResponseString(std::string((char*)kPNGImage, sizeof(kPNGImage))); | |
185 fetcher->delegate()->OnURLFetchComplete(fetcher); | |
186 EXPECT_NE(nil, result_); | |
187 EXPECT_TRUE(called_); | |
188 } | |
189 | |
190 TEST_F(IOSImageDataFetcherWrapperTest, TestGoodWebP) { | |
191 net::TestURLFetcher* fetcher = SetupFetcher(); | |
192 fetcher->set_response_code(200); | |
193 fetcher->SetResponseString( | |
194 std::string((char*)kWEBPImage, sizeof(kWEBPImage))); | |
195 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders( | |
196 std::string(kWEBPHeaderResponse, arraysize(kWEBPHeaderResponse)))); | |
197 fetcher->set_response_headers(headers); | |
198 fetcher->delegate()->OnURLFetchComplete(fetcher); | |
199 worker_thread_.FlushForTesting(); | |
200 base::RunLoop().RunUntilIdle(); | |
201 EXPECT_NE(nil, result_); | |
202 EXPECT_TRUE(called_); | |
203 } | |
204 | |
205 TEST_F(IOSImageDataFetcherWrapperTest, TestGoodWebPNoHeader) { | |
206 net::TestURLFetcher* fetcher = SetupFetcher(); | |
207 fetcher->set_response_code(200); | |
208 fetcher->SetResponseString( | |
209 std::string((char*)kWEBPImage, sizeof(kWEBPImage))); | |
210 fetcher->delegate()->OnURLFetchComplete(fetcher); | |
211 worker_thread_.FlushForTesting(); | |
212 base::RunLoop().RunUntilIdle(); | |
213 EXPECT_TRUE([DecodedWebpImage() isEqualToData:result_data_]); | |
214 EXPECT_TRUE(called_); | |
215 } | |
216 | |
217 TEST_F(IOSImageDataFetcherWrapperTest, TestBadWebP) { | |
218 net::TestURLFetcher* fetcher = SetupFetcher(); | |
219 fetcher->set_response_code(200); | |
220 fetcher->SetResponseString("This is not a valid WebP image"); | |
221 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders( | |
222 std::string(kWEBPHeaderResponse, arraysize(kWEBPHeaderResponse)))); | |
223 fetcher->set_response_headers(headers); | |
224 fetcher->delegate()->OnURLFetchComplete(fetcher); | |
225 worker_thread_.FlushForTesting(); | |
226 base::RunLoop().RunUntilIdle(); | |
227 EXPECT_EQ(nil, result_); | |
228 EXPECT_TRUE(called_); | |
229 } | |
230 | |
231 TEST_F(IOSImageDataFetcherWrapperTest, DeleteDuringWebPDecoding) { | |
232 net::TestURLFetcher* fetcher = SetupFetcher(); | |
233 fetcher->set_response_code(200); | |
234 fetcher->SetResponseString( | |
235 std::string((char*)kWEBPImage, sizeof(kWEBPImage))); | |
236 fetcher->delegate()->OnURLFetchComplete(fetcher); | |
237 // Delete the image fetcher, and check that the callback is called. | |
238 image_fetcher_.reset(); | |
239 worker_thread_.FlushForTesting(); | |
240 base::RunLoop().RunUntilIdle(); | |
241 EXPECT_TRUE([DecodedWebpImage() isEqualToData:result_data_]); | |
242 EXPECT_TRUE(called_); | |
243 } | |
244 | |
245 TEST_F(IOSImageDataFetcherWrapperTest, TestCallbacksNotCalledDuringDeletion) { | |
246 image_fetcher_->FetchImageDataWebpDecoded(GURL(kTestUrl), callback_); | |
247 image_fetcher_.reset(); | |
248 EXPECT_FALSE(called_); | |
249 } | |
250 | |
251 } // namespace image_fetcher | |
OLD | NEW |