Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: ui/views/test/widget_test_aura.cc

Issue 2663163004: Run the "Relaunch Chrome" dialog test everywhere. (Closed)
Patch Set: Add back the fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/update_chrome_dialog_browsertest.cc ('k') | ui/views/test/widget_test_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/test/widget_test_aura.cc
diff --git a/ui/views/test/widget_test_aura.cc b/ui/views/test/widget_test_aura.cc
index 8cabaf5cf256a5634350549cb3f7e8ccdf606520..53af04557b2b0743e37927e8208e277471f65074 100644
--- a/ui/views/test/widget_test_aura.cc
+++ b/ui/views/test/widget_test_aura.cc
@@ -163,10 +163,10 @@ bool WidgetTest::IsNativeWindowTransparent(gfx::NativeWindow window) {
// static
Widget::Widgets WidgetTest::GetAllWidgets() {
- std::vector<aura::Window*> toplevel = GetAllTopLeveLWindows();
+ std::vector<aura::Window*> toplevels = GetAllTopLeveLWindows();
sky 2017/02/06 17:29:47 optional: don't bother with local, change for to:
sky 2017/02/06 17:29:47 How about fixing the capitalization here, e.g. "Le
tapted 2017/02/06 22:50:49 Ach - thanks. Done.
tapted 2017/02/06 22:50:49 Done.
Widget::Widgets all_widgets;
- for (aura::Window* root : toplevel)
- Widget::GetAllChildWidgets(root, &all_widgets);
+ for (aura::Window* window : toplevels)
+ Widget::GetAllChildWidgets(window->GetRootWindow(), &all_widgets);
return all_widgets;
}
« no previous file with comments | « chrome/browser/ui/update_chrome_dialog_browsertest.cc ('k') | ui/views/test/widget_test_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698