chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc - Issue 2663163002: MD settings: Storage: Add DELETE button for deleting Drive offline files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc

Issue 2663163002: MD settings: Storage: Add DELETE button for deleting Drive offline files. (Closed)

Patch Set: Make rows two-line and use icon for deleting drive cache. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/device_page/storage.html ('K') | « chrome/browser/resources/settings/device_page/storage.js ('k') | ui/webui/resources/cr_elements_images.grdp » ('j') | ui/webui/resources/images/delete.svg » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc

diff --git a/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc b/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc

index 3d68dc90d9c671a8d2966b6e92d46c4d15cf470b..7e2ebbc188435ccbc6384178b2c59462682e0ad9 100644

--- a/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc

+++ b/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc

@@ -217,7 +217,8 @@ void StorageHandler::OnGetDriveCacheSize(int64_t size) {

updating_drive_cache_size_ = false;

CallJavascriptFunction("cr.webUIListenerCallback",

base::StringValue("storage-drive-cache-size-changed"),

- base::StringValue(ui::FormatBytes(size)));

+ base::StringValue(ui::FormatBytes(size)),

+ base::FundamentalValue(size > 0));

}

void StorageHandler::UpdateBrowsingDataSize() {