chrome/browser/resources/settings/languages_page/languages_page.html - Issue 2663083002: MD Settings: Migrate enable-translation toggle from non-MD settings page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2663083002: MD Settings: Migrate enable-translation toggle from non-MD settings page. (Closed)

Patch Set: fix tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | chrome/test/data/webui/settings/languages_page_browsertest.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/languages_page/languages_page.html

diff --git a/chrome/browser/resources/settings/languages_page/languages_page.html b/chrome/browser/resources/settings/languages_page/languages_page.html

index 00635ba61142d3fb1cfe3e56e57a7c6d71919815..df3f562e3828922ddacdf1faadc4e8ba624ebd44 100644

--- a/chrome/browser/resources/settings/languages_page/languages_page.html

+++ b/chrome/browser/resources/settings/languages_page/languages_page.html

@@ -87,16 +87,16 @@

</cr-expand-button>

</div>

<iron-collapse id="languagesCollapse" opened="[[languagesOpened_]]">

- <div class="list-frame vertical-list">

- <span class="list-item"

- hidden="[[isHelpTextHidden_(languages.enabled.*)]]">

- <span>$i18n{orderLanguagesInstructions}</span>

+ <span class="settings-box first"

+ hidden="[[isHelpTextHidden_(languages.enabled.*)]]">

+ <span>$i18n{orderLanguagesInstructions}</span>

- <a href="$i18n{languagesLearnMoreURL}" target="_blank">

- $i18n{learnMore}

- </a>

+ <a href="$i18n{languagesLearnMoreURL}" target="_blank">

+ $i18n{learnMore}

+ </a>

</if>

- </span>

+ </span>

+ <div class="list-frame vertical-list">

<div class$="list-item [[getLanguageItemClass_(

item.language.code, language.prospectiveUILanguage)]]">

@@ -133,6 +133,12 @@

</a>

</div>

+ <div class="settings-box first">

+ <settings-toggle-button id="offerTranslateOtherLangs" class="start"

+ pref="{{prefs.translate.enabled}}"

+ label="$i18n{offerToEnableTranslate}">

+ </settings-toggle-button>

+ </div>

</iron-collapse>

<div id="manageInputMethodsSubpageTrigger"