Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1693)

Unified Diff: appengine/findit/model/crash/chrome_crash_analysis.py

Issue 2663063007: [Predator] Switch from anonymous dict to CrashData. (Closed)
Patch Set: Rebase and fix delta test. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/crash/chrome_crash_analysis.py
diff --git a/appengine/findit/model/crash/chrome_crash_analysis.py b/appengine/findit/model/crash/chrome_crash_analysis.py
index fed1df2cfa3c7fac64d102381bebc2c2da1ce50f..3fc973abc586b6a1a3fe654ec6b454e05573f991 100644
--- a/appengine/findit/model/crash/chrome_crash_analysis.py
+++ b/appengine/findit/model/crash/chrome_crash_analysis.py
@@ -18,7 +18,8 @@ class ChromeCrashAnalysis(CrashAnalysis):
self.historical_metadata = None
self.channel = None
- @property
- def customized_data(self):
- return {'historical_metadata': self.historical_metadata,
- 'channel': self.channel}
+ def Initialize(self, crash_data):
+ """(Re)Initializes a CrashAnalysis ndb.Model from ``ChromeCrashData``."""
+ super(ChromeCrashAnalysis, self).Initialize(crash_data)
+ self.channel = crash_data.channel
+ self.historical_metadata = crash_data.historical_metadata
« no previous file with comments | « appengine/findit/handlers/crash/test/triage_fracas_analysis_test.py ('k') | appengine/findit/model/crash/crash_analysis.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698