appengine/findit/model/crash/chrome_crash_analysis.py - Issue 2663063007: [Predator] Switch from anonymous dict to CrashData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/model/crash/chrome_crash_analysis.py

Issue 2663063007: [Predator] Switch from anonymous dict to CrashData. (Closed)

Patch Set: Rebase. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/model/crash/chrome_crash_analysis.py

diff --git a/appengine/findit/model/crash/chrome_crash_analysis.py b/appengine/findit/model/crash/chrome_crash_analysis.py

index fed1df2cfa3c7fac64d102381bebc2c2da1ce50f..92c3c57c431f48709dc87f4626ed9430ca4d63d1 100644

--- a/appengine/findit/model/crash/chrome_crash_analysis.py

+++ b/appengine/findit/model/crash/chrome_crash_analysis.py

@@ -22,3 +22,9 @@ class ChromeCrashAnalysis(CrashAnalysis):

def customized_data(self):

return {'historical_metadata': self.historical_metadata,

'channel': self.channel}

+ def Initialize(self, crash_buffer):

+ """(Re)Initializes a CrashAnalysis ndb.Model from ``ChromeCrashBuffer``."""

+ super(ChromeCrashAnalysis, self).Initialize(crash_buffer)

+ self.channel = crash_buffer.channel

+ self.historical_metadata = crash_buffer.historical_metadata