Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2691)

Unified Diff: appengine/findit/crash/test/predator_testcase.py

Issue 2663063007: [Predator] Switch from anonymous dict to CrashData. (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/predator_testcase.py
diff --git a/appengine/findit/crash/test/predator_testcase.py b/appengine/findit/crash/test/predator_testcase.py
index 2a888ed24775c3bb3a8b1bcdc563ae4050008f73..dc69c08e8f23caffb93b6a65b8e9806cce6aa73f 100644
--- a/appengine/findit/crash/test/predator_testcase.py
+++ b/appengine/findit/crash/test/predator_testcase.py
@@ -109,7 +109,6 @@ class PredatorTestCase(TestCase): # pragma: no cover
def GetMockFindit(self, get_repository=None, config=None,
client_id='mock_client'):
- """Gets Mocked ``Findit`` object."""
get_repository = (get_repository or
GitilesRepository.Factory(self.GetMockHttpClient()))
config = config or CrashConfig.Get()
@@ -126,6 +125,27 @@ class PredatorTestCase(TestCase): # pragma: no cover
def ProcessResultForPublishing(self, result, key):
return result
+ def GetCrashBuffer(self, crash_data):
+
+ class MockCrashBuffer(CrashBuffer):
+ @property
+ def regression_range(self):
+ return crash_data.get('regression_range')
+
+ @property
+ def stacktrace(self):
+ return None
+
+ @property
+ def dependencies(self):
+ return {}
+
+ @property
+ def dependency_rolls(self):
+ return {}
+
+ return MockCrashBuffer(crash_data)
+
def GetAnalysis(self, crash_identifiers):
return CrashAnalysis.Get(crash_identifiers)
@@ -139,7 +159,6 @@ class PredatorTestCase(TestCase): # pragma: no cover
stack_trace=None, regression_range=None,
channel='canary', historical_metadata=None,
crash_identifiers=True, process_type='browser'):
- """Gets Mocked crashed_data sent by clients."""
if crash_identifiers is True: # pragma: no cover
crash_identifiers = {
'chrome_version': version,

Powered by Google App Engine
This is Rietveld 408576698