Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2474)

Unified Diff: appengine/findit/crash/crash_pipeline.py

Issue 2663063007: [Predator] Switch from anonymous dict to CrashData. (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/findit/crash/crash_report.py » ('j') | appengine/findit/crash/findit.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/crash_pipeline.py
diff --git a/appengine/findit/crash/crash_pipeline.py b/appengine/findit/crash/crash_pipeline.py
index 7966d0c5c4edc4444f51401ba311f4b49ab8ef38..0460345dbd769270213bd66a184512aef730b036 100644
--- a/appengine/findit/crash/crash_pipeline.py
+++ b/appengine/findit/crash/crash_pipeline.py
@@ -19,10 +19,11 @@ from libs import time_util
from gae_libs.gitiles.cached_gitiles_repository import CachedGitilesRepository
from gae_libs.http.http_client_appengine import HttpClientAppengine
from model import analysis_status
+from model.crash.crash_config import CrashConfig
# TODO(http://crbug.com/659346): write complete coverage tests for this.
-def FinditForClientID(client_id, get_repository): # pragma: no cover
+def FinditForClientID(client_id, get_repository, config): # pragma: no cover
"""Construct a Findit object from a client id string specifying the class.
We cannot pass Findit objects to the various methods in
@@ -52,7 +53,7 @@ def FinditForClientID(client_id, get_repository): # pragma: no cover
raise ValueError('FinditForClientID: '
'unknown or unsupported client %s' % client_id)
- return cls(get_repository)
+ return cls(get_repository, config)
# Some notes about the classes below, for people who are not familiar
@@ -93,7 +94,8 @@ class CrashBasePipeline(BasePipeline):
self._crash_identifiers = crash_identifiers
self._findit = FinditForClientID(
client_id,
- CachedGitilesRepository.Factory(HttpClientAppengine()))
+ CachedGitilesRepository.Factory(HttpClientAppengine()),
+ CrashConfig.Get())
@property
def client_id(self): # pragma: no cover
@@ -139,7 +141,7 @@ class CrashAnalysisPipeline(CrashBasePipeline):
analysis.put()
# Actually do the analysis.
- culprit = self._findit.FindCulprit(analysis)
+ culprit = self._findit.FindCulprit(analysis.ToCrashReport())
if culprit is not None:
result, tags = culprit.ToDicts()
else:
« no previous file with comments | « no previous file | appengine/findit/crash/crash_report.py » ('j') | appengine/findit/crash/findit.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698