| Index: appengine/findit/crash/crash_pipeline.py
|
| diff --git a/appengine/findit/crash/crash_pipeline.py b/appengine/findit/crash/crash_pipeline.py
|
| index 7966d0c5c4edc4444f51401ba311f4b49ab8ef38..0460345dbd769270213bd66a184512aef730b036 100644
|
| --- a/appengine/findit/crash/crash_pipeline.py
|
| +++ b/appengine/findit/crash/crash_pipeline.py
|
| @@ -19,10 +19,11 @@ from libs import time_util
|
| from gae_libs.gitiles.cached_gitiles_repository import CachedGitilesRepository
|
| from gae_libs.http.http_client_appengine import HttpClientAppengine
|
| from model import analysis_status
|
| +from model.crash.crash_config import CrashConfig
|
|
|
|
|
| # TODO(http://crbug.com/659346): write complete coverage tests for this.
|
| -def FinditForClientID(client_id, get_repository): # pragma: no cover
|
| +def FinditForClientID(client_id, get_repository, config): # pragma: no cover
|
| """Construct a Findit object from a client id string specifying the class.
|
|
|
| We cannot pass Findit objects to the various methods in
|
| @@ -52,7 +53,7 @@ def FinditForClientID(client_id, get_repository): # pragma: no cover
|
| raise ValueError('FinditForClientID: '
|
| 'unknown or unsupported client %s' % client_id)
|
|
|
| - return cls(get_repository)
|
| + return cls(get_repository, config)
|
|
|
|
|
| # Some notes about the classes below, for people who are not familiar
|
| @@ -93,7 +94,8 @@ class CrashBasePipeline(BasePipeline):
|
| self._crash_identifiers = crash_identifiers
|
| self._findit = FinditForClientID(
|
| client_id,
|
| - CachedGitilesRepository.Factory(HttpClientAppengine()))
|
| + CachedGitilesRepository.Factory(HttpClientAppengine()),
|
| + CrashConfig.Get())
|
|
|
| @property
|
| def client_id(self): # pragma: no cover
|
| @@ -139,7 +141,7 @@ class CrashAnalysisPipeline(CrashBasePipeline):
|
| analysis.put()
|
|
|
| # Actually do the analysis.
|
| - culprit = self._findit.FindCulprit(analysis)
|
| + culprit = self._findit.FindCulprit(analysis.ToCrashReport())
|
| if culprit is not None:
|
| result, tags = culprit.ToDicts()
|
| else:
|
|
|