Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: appengine/findit/crash/crash_pipeline.py

Issue 2663063007: [Predator] Switch from anonymous dict to CrashData. (Closed)
Patch Set: Rebase and fix delta test. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | appengine/findit/crash/crash_report.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import copy 5 import copy
6 import json 6 import json
7 import logging 7 import logging
8 8
9 from crash import monitoring 9 from crash import monitoring
10 10
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 analysis = self._findit.GetAnalysis(self._crash_identifiers) 134 analysis = self._findit.GetAnalysis(self._crash_identifiers)
135 135
136 # Update the model's status to say we're in the process of doing analysis. 136 # Update the model's status to say we're in the process of doing analysis.
137 analysis.pipeline_status_path = self.pipeline_status_path() 137 analysis.pipeline_status_path = self.pipeline_status_path()
138 analysis.status = analysis_status.RUNNING 138 analysis.status = analysis_status.RUNNING
139 analysis.started_time = time_util.GetUTCNow() 139 analysis.started_time = time_util.GetUTCNow()
140 analysis.findit_version = appengine_util.GetCurrentVersion() 140 analysis.findit_version = appengine_util.GetCurrentVersion()
141 analysis.put() 141 analysis.put()
142 142
143 # Actually do the analysis. 143 # Actually do the analysis.
144 culprit = self._findit.FindCulprit(analysis) 144 culprit = self._findit.FindCulprit(analysis.ToCrashReport())
145 if culprit is not None: 145 if culprit is not None:
146 result, tags = culprit.ToDicts() 146 result, tags = culprit.ToDicts()
147 else: 147 else:
148 result = {'found': False} 148 result = {'found': False}
149 tags = { 149 tags = {
150 'found_suspects': False, 150 'found_suspects': False,
151 'found_project': False, 151 'found_project': False,
152 'found_components': False, 152 'found_components': False,
153 'has_regression_range': False, 153 'has_regression_range': False,
154 'solution': None, 154 'solution': None,
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 N.B., due to the structure of AppEngine pipelines, this method must 231 N.B., due to the structure of AppEngine pipelines, this method must
232 accept the same arguments as are passed to ``__init__``; however, 232 accept the same arguments as are passed to ``__init__``; however,
233 because they were already passed to ``__init__`` there's no use in 233 because they were already passed to ``__init__`` there's no use in
234 recieving them here. Thus, we discard all the arguments to this method 234 recieving them here. Thus, we discard all the arguments to this method
235 (except for ``self``, naturally). 235 (except for ``self``, naturally).
236 """ 236 """
237 run_analysis = yield CrashAnalysisPipeline( 237 run_analysis = yield CrashAnalysisPipeline(
238 self._client_id, self._crash_identifiers) 238 self._client_id, self._crash_identifiers)
239 with pipeline.After(run_analysis): 239 with pipeline.After(run_analysis):
240 yield PublishResultPipeline(self._client_id, self._crash_identifiers) 240 yield PublishResultPipeline(self._client_id, self._crash_identifiers)
OLDNEW
« no previous file with comments | « no previous file | appengine/findit/crash/crash_report.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698