Move the kernel isolate snapshot out of the 'runtime' target to reduce build times on the simulator…

Move the kernel isolate snapshot out of the 'runtime' target to reduce build times on the simulators.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/b93307ea92eb42c41d57be1e0786f9509e440af6

[rmacnak, 2017-01-31 22:23:55]

rmacnak@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2017-01-31 22:29:04]

Thanks! Lgtm.

[rmacnak, 2017-01-31 22:46:35]

Description was changed from

==========
Move the kernel isolate snapshot out of the 'runtime' target to reduce build
times on the simulators.
==========

to

==========
Move the kernel isolate snapshot out of the 'runtime' target to reduce build
times on the simulators.

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b93307ea92eb42c41d57be1e0786f9509e440af6
==========

[rmacnak, 2017-01-31 22:46:36]

Committed patchset #1 (id:1) manually as
b93307ea92eb42c41d57be1e0786f9509e440af6 (presubmit successful).

[jamesr1, 2017-01-31 23:10:02]

jamesr@google.com changed reviewers:
+ jamesr@google.com

[jamesr1, 2017-01-31 23:10:02]

https://codereview.chromium.org/2663063006/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2663063006/diff/1/BUILD.gn#newcode50
BUILD.gn:50: ":runtime",
unfortunately this breaks the fuchsia GN build as this non-testonly target now
depends on a target marked testonly in fuchsia, see line 35.  Why does
//dart:runtime depend on run_vm_tests?  Is that not actually a test-only target
or should //dart:runtime (and thus //dart:runtime_kernel) be considered testonly
as well?

[rmacnak, 2017-01-31 23:26:10]

https://codereview.chromium.org/2663063006/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2663063006/diff/1/BUILD.gn#newcode50
BUILD.gn:50: ":runtime",
On 2017/01/31 23:10:02, jamesr1 wrote:
> unfortunately this breaks the fuchsia GN build as this non-testonly target now
> depends on a target marked testonly in fuchsia, see line 35.  Why does
> //dart:runtime depend on run_vm_tests?  Is that not actually a test-only
target
> or should //dart:runtime (and thus //dart:runtime_kernel) be considered
testonly
> as well?

runtime and runtime_kernel should have the same testonly-ness.

I believe the grouping of run_vm_tests under runtime is mostly historical: we
did it that way in GYP, our bots build the "runtime" target and we're keeping GN
and GYP roughly in sync until we can stop supporting GN. This probably should be
refactored after that.

[rmacnak, 2017-01-31 23:32:31]

On 2017/01/31 23:26:10, rmacnak wrote:
> https://codereview.chromium.org/2663063006/diff/1/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/2663063006/diff/1/BUILD.gn#newcode50
> BUILD.gn:50: ":runtime",
> On 2017/01/31 23:10:02, jamesr1 wrote:
> > unfortunately this breaks the fuchsia GN build as this non-testonly target
now
> > depends on a target marked testonly in fuchsia, see line 35.  Why does
> > //dart:runtime depend on run_vm_tests?  Is that not actually a test-only
> target
> > or should //dart:runtime (and thus //dart:runtime_kernel) be considered
> testonly
> > as well?
> 
> runtime and runtime_kernel should have the same testonly-ness.
> 
> I believe the grouping of run_vm_tests under runtime is mostly historical: we
> did it that way in GYP, our bots build the "runtime" target and we're keeping
GN
> and GYP roughly in sync until we can stop supporting GN. This probably should
be
> refactored after that.

er, stop supporting GYP*