Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2663033004: Prepare equivalence strategies for testing entities. (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -71 lines) Patch
M pkg/compiler/lib/src/constants/constant_constructors.dart View 1 chunk +6 lines, -0 lines 1 comment Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 5 chunks +46 lines, -19 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 3 chunks +21 lines, -52 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
https://codereview.chromium.org/2663033004/diff/1/pkg/compiler/lib/src/constants/constant_constructors.dart File pkg/compiler/lib/src/constants/constant_constructors.dart (right): https://codereview.chromium.org/2663033004/diff/1/pkg/compiler/lib/src/constants/constant_constructors.dart#newcode294 pkg/compiler/lib/src/constants/constant_constructors.dart:294: ConstantExpression visitTopLevelFunctionGet( Needed to handle dart2js_resolver_test on the added ...
3 years, 10 months ago (2017-01-31 13:05:16 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-01-31 21:38:03 UTC) #3
Johnni Winther
3 years, 10 months ago (2017-02-01 09:05:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
26f8509fee7bae76af3c4d111d3777ffb257e27e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698