Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(1263)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: test/mjsunit/proto-elements-add-during-foreach.js
Issue
2663033003
:
[builtins] TurboFan version of Array.prototype.forEach including fast path for FAST_ELEMENTS (Closed)
Patch Set: Review feedback
Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
src/bootstrapper.cc
src/builtins/builtins.h
src/builtins/builtins-array.cc
src/flag-definitions.h
src/interface-descriptors.h
src/js/array.js
src/runtime/runtime-array.cc
test/mjsunit/proto-elements-add-during-foreach.js
View unified diff
|
Download patch
« no previous file with comments
|
« src/runtime/runtime-array.cc
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2015 the V8 project authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
// Flags: --enable-fast-array-builtins
6
7
var a = [0,1,2,,,,7];
8
var proto = {}
9
a.__proto__ = proto;
10
var visits = 0;
11
Array.prototype.forEach.call(a, (v,i,o) => { ++visits; proto[4] = 4; });
12
assertEquals(5, visits);
OLD
NEW
« no previous file with comments
|
« src/runtime/runtime-array.cc
('k') |
no next file »
|
no next file with comments »
Issue 2663033003: [builtins] TurboFan version of Array.prototype.forEach including fast path for FAST_ELEMENTS (Closed)
Created 3 years, 10 months ago by danno
Modified 3 years, 10 months ago
Reviewers: Benedikt Meurer, Yang
Base URL:
Comments: 12
This is Rietveld
408576698
Chromium Code Reviews
Issue 2663033003:
[builtins] TurboFan version of Array.prototype.forEach including fast path for FAST_ELEMENTS (Closed)
