Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2662983005: Fix for resynthesizing invalid elements as type arguments of declared types. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for resynthesizing invalid elements as type arguments of declared types. Reproduced using Brian's stress test. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/54c8496a3831abd285cfd945248ae2bdf0d098dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-01-31 22:21:17 UTC) #1
Paul Berry
lgtm
3 years, 10 months ago (2017-01-31 22:26:39 UTC) #2
scheglov
3 years, 10 months ago (2017-01-31 22:28:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
54c8496a3831abd285cfd945248ae2bdf0d098dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698