Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 2662973005: Suppress NO_DEFAULT_BOUND errors. (Closed)

Created:
3 years, 10 months ago by Leaf
Modified:
3 years, 10 months ago
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Suppress NO_DEFAULT_BOUND errors. This suppresses the emission of NO_DEFAULT_BOUND errors, and makes the default instantation for recursive bounds backwards (and possibly forwards) compatible. Also adds a couple of currently failing tests for cases that should be made erroneous regardless of whether we choose to support malbounded type constructor applications. BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/3fa3964a70024787e8fbde9208815aeb0658608f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -71 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 2 chunks +19 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 7 chunks +96 lines, -53 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/dev_compiler/test/not_yet_strong_tests.dart View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
We're pushing off this error for one release to unblock good the google3 roll.
3 years, 10 months ago (2017-02-01 17:21:17 UTC) #2
scheglov
lgtm
3 years, 10 months ago (2017-02-01 17:25:42 UTC) #3
Leaf
3 years, 10 months ago (2017-02-01 18:18:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3fa3964a70024787e8fbde9208815aeb0658608f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698