Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2662873002: Fix test status (Closed)

Created:
3 years, 10 months ago by vsm
Modified:
3 years, 10 months ago
Reviewers:
Leaf, Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix test status Started breaking with leaf's cl on Fri. Note, a very recent test (I think) is not strong clean any more. Rewrite it? TBR=leafp@google.com,rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/154cd39db8d9efba9f47bc463df44ef8c37710de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M pkg/dev_compiler/test/not_yet_strong_tests.dart View 3 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
vsm
Committed patchset #1 (id:1) manually as 154cd39db8d9efba9f47bc463df44ef8c37710de (presubmit successful).
3 years, 10 months ago (2017-01-30 16:08:18 UTC) #2
Bob Nystrom
3 years, 10 months ago (2017-01-31 19:21:09 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698