Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2662703002: Update rasta outline expectations. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased on 0401b897958de33f8481b9cb323eab53106a3ce9. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+489 lines, -1211 lines) Patch
M pkg/front_end/test/fasta/rasta/abstract_constructor.dart.outline.expect View 1 1 chunk +4 lines, -5 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/bad_constructor_redirection.dart.outline.expect View 1 1 chunk +5 lines, -8 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/bad_continue.dart.outline.expect View 1 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/bad_default_constructor.dart.outline.expect View 1 1 chunk +5 lines, -8 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/bad_explicit_super_constructor.dart.outline.expect View 1 1 chunk +4 lines, -8 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/bad_implicit_super_constructor.dart.outline.expect View 1 1 chunk +4 lines, -8 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/bad_interpolation.dart.outline.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/bad_redirection.dart.outline.expect View 1 1 chunk +5 lines, -7 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/bad_setter_initializer.dart.outline.expect View 1 1 chunk +5 lines, -6 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/bad_unicode.dart.outline.expect View 1 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/breaking_bad.dart.outline.expect View 1 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/cascades.dart.outline.expect View 1 1 chunk +5 lines, -9 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/class_hierarchy.dart.outline.expect View 1 1 chunk +9 lines, -13 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/class_member.dart.outline.expect View 1 1 chunk +9 lines, -9 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/constant_get_and_invoke.dart.outline.expect View 1 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/deferred_lib.dart.outline.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/deferred_load.dart.outline.expect View 1 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/duplicated_mixin.dart.outline.expect View 1 1 chunk +7 lines, -13 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/enum.dart.outline.expect View 1 1 chunk +8 lines, -6 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/external_factory_redirection.dart.outline.expect View 1 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/foo.dart.outline.expect View 1 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/for_loop.dart.outline.expect View 1 1 chunk +2 lines, -10 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/generic_factory.dart.outline.expect View 1 2 chunks +12 lines, -20 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/hello.dart.outline.expect View 1 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/import_export.dart.outline.expect View 1 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000001.dart.outline.expect View 1 1 chunk +4 lines, -7 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000002.dart.outline.expect View 1 1 chunk +7 lines, -12 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000004.dart.outline.expect View 1 1 chunk +8 lines, -30 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000006.dart.outline.expect View 1 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000007.dart.outline.expect View 1 1 chunk +11 lines, -16 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000008.dart.outline.expect View 1 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000011.dart.outline.expect View 1 1 chunk +2 lines, -9 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000012.dart.outline.expect View 1 1 chunk +8 lines, -10 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000025.dart.outline.expect View 1 1 chunk +5 lines, -7 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000026.dart.outline.expect View 1 1 chunk +5 lines, -8 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000031.dart.outline.expect View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000032.dart.outline.expect View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000033.dart.outline.expect View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000034.dart.outline.expect View 1 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000035.dart.outline.expect View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000036.dart.outline.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000039.dart.outline.expect View 1 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000041.dart.outline.expect View 1 1 chunk +7 lines, -9 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000042.dart.outline.expect View 1 1 chunk +2 lines, -23 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000043.dart.outline.expect View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000044.dart.outline.expect View 1 1 chunk +8 lines, -15 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000046.dart.outline.expect View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000047.dart.outline.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000048.dart.outline.expect View 1 1 chunk +10 lines, -11 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000052.dart.outline.expect View 1 1 chunk +2 lines, -7 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000053.dart.outline.expect View 1 1 chunk +8 lines, -10 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000067.dart.outline.expect View 1 1 chunk +15 lines, -19 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000068.dart.outline.expect View 1 1 chunk +10 lines, -18 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000069.dart.outline.expect View 1 1 chunk +2 lines, -7 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000070.dart.outline.expect View 1 1 chunk +18 lines, -30 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000080.dart.outline.expect View 1 1 chunk +11 lines, -19 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000081.dart.outline.expect View 1 1 chunk +9 lines, -13 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/malformed_const_constructor.dart.outline.expect View 1 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/malformed_function.dart.outline.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/malformed_function_type.dart.outline.expect View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/mandatory_parameter_initializer.dart.outline.expect View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/mixin_library.dart.outline.expect View 1 1 chunk +12 lines, -12 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/native_is_illegal.dart.outline.expect View 1 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/parser_error.dart.outline.expect View 1 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/previsit_deferred.dart.outline.expect View 1 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/static.dart.outline.expect View 1 1 chunk +13 lines, -73 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/super.dart.outline.expect View 1 1 chunk +36 lines, -235 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/super_initializer.dart.outline.expect View 1 1 chunk +6 lines, -12 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/super_mixin.dart.outline.expect View 1 1 chunk +46 lines, -48 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/super_operator.dart.outline.expect View 1 1 chunk +14 lines, -13 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/supports_reflection.dart.outline.expect View 1 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/switch_execution_case_t02.dart.outline.expect View 1 1 chunk +6 lines, -56 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/switch_fall_through.dart.outline.expect View 1 1 chunk +2 lines, -53 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/this_invoke.dart.outline.expect View 1 1 chunk +6 lines, -7 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/try_label.dart.outline.expect View 1 1 chunk +2 lines, -9 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/type_literals.dart.outline.expect View 1 1 chunk +8 lines, -91 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/type_with_parse_error.dart.outline.expect View 1 1 chunk +8 lines, -10 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/typedef.dart.outline.expect View 1 1 chunk +2 lines, -7 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/unresolved.dart.outline.expect View 1 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/unresolved_constructor.dart.outline.expect View 1 1 chunk +3 lines, -6 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/unresolved_for_in.dart.outline.expect View 1 1 chunk +6 lines, -47 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/unresolved_recovery.dart.outline.expect View 1 1 chunk +9 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
Expect to see this: * method bodies removed (outlines have no method bodies). * field ...
3 years, 10 months ago (2017-01-27 23:06:33 UTC) #2
karlklose
LGTM
3 years, 10 months ago (2017-01-31 11:27:21 UTC) #3
ahe
3 years, 10 months ago (2017-02-01 12:29:56 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
5f1092d494bc8cae2b10917fc41c46764e867923 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698